Fix DCHECK, memory leak, and refactor PasswordStore to use CancelableRequest

base/scoped_vector.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_SCOPED_VECTOR_H_
 #define BASE_SCOPED_VECTOR_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 36 matching lines @@
 
   std::vector<T*>& get() { return v; }
   const std::vector<T*>& get() const { return v; }
   void swap(ScopedVector<T>& other) { v.swap(other.v); }
   void release(std::vector<T*>* out) {
     out->swap(v);
     v.clear();
   }
 
   void reset() { STLDeleteElements(&v); }
+  void reset(const std::vector<T*>& vec) {

[James Hawkins, 2011/03/16 22:39:35]

You're essentially adding operator= by another name. I'm concerned about
overloading reset(). A few options (each with pros/cons):
* Don't use DISALLOW_COPY_AND_ASSIGN, override operator=().
* Rename this to copy().

[Sheridan Rawlins, 2011/03/18 15:45:48]

Ok, discussing alternative as you know on chromium-dev

[Sheridan Rawlins, 2011/03/20 08:13:11]

I'd like to tackle the idea of moving ScopedVector to the PasswordStoreRequest
object and transferring ownership with a swap, in a separate CL.

+    reset();
+    v = vec;
+  }

[stuartmorgan, 2011/03/16 23:25:20]

I don't feel comfortable being the reviewer for adding new functionality to a
base/ class I'm not involved in. I'd suggest splitting this off into a
completely different CL, but failing that this CL needs another reviewer.

[Sheridan Rawlins, 2011/03/18 15:45:48]

This may be moot if I take alternative.  o/w I'll add another reviewer.

[Sheridan Rawlins, 2011/03/20 08:13:11]

Nico seems to have some commits in base/scoped_vector.h I'll add him.

   void reserve(size_t capacity) { v.reserve(capacity); }
   void resize(size_t new_size) { v.resize(new_size); }
 
   // Lets the ScopedVector take ownership of |x|.
   iterator insert(iterator position, T* x) {
     return v.insert(position, x);
   }
 
   iterator erase(iterator position) {
     delete *position;
@@ skipping 14 matching lines @@
   iterator weak_erase(iterator first, iterator last) {
     return v.erase(first, last);
   }
  private:
   std::vector<T*> v;
 
   DISALLOW_COPY_AND_ASSIGN(ScopedVector);
 };
 
 #endif  // BASE_SCOPED_VECTOR_H_