Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 6646047: X64 Crankshaft: Fix error in computation of sine and cosine. (Closed)

Created:
9 years, 9 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund, Rico
CC:
v8-dev
Visibility:
Public.

Description

X64 Crankshaft: Fix error in computation of sine and cosine. Committed: http://code.google.com/p/v8/source/detail?r=7129

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M src/x64/lithium-codegen-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/sin-cos.js View 1 2 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
William Hesse
9 years, 9 months ago (2011-03-10 13:18:07 UTC) #1
Kasper Lund
LGTM :-) We should push this to trunk ASAP.
9 years, 9 months ago (2011-03-10 13:19:38 UTC) #2
William Hesse
Added regression test.
9 years, 9 months ago (2011-03-10 13:32:26 UTC) #3
Rico
9 years, 9 months ago (2011-03-10 13:33:34 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698