Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: tests/presubmit_unittest.py

Issue 6646040: suppress messages for PresubmitAddText results (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« presubmit_support.py ('K') | « presubmit_support.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Unit tests for presubmit_support.py and presubmit_canned_checks.py.""" 6 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
7 7
8 # pylint is too confused. 8 # pylint is too confused.
9 # pylint: disable=E1101,E1103,W0212,W0403 9 # pylint: disable=E1101,E1103,W0212,W0403
10 10
(...skipping 1027 matching lines...) Expand 10 before | Expand all | Expand 10 after
1038 members = [ 1038 members = [
1039 'MailTextResult', 'PresubmitAddText', 'PresubmitError', 1039 'MailTextResult', 'PresubmitAddText', 'PresubmitError',
1040 'PresubmitNotifyResult', 'PresubmitPromptWarning', 'PresubmitResult', 1040 'PresubmitNotifyResult', 'PresubmitPromptWarning', 'PresubmitResult',
1041 ] 1041 ]
1042 # If this test fails, you should add the relevant test. 1042 # If this test fails, you should add the relevant test.
1043 self.compareMembers(presubmit.OutputApi(), members) 1043 self.compareMembers(presubmit.OutputApi(), members)
1044 1044
1045 def testOutputApiBasics(self): 1045 def testOutputApiBasics(self):
1046 self.mox.ReplayAll() 1046 self.mox.ReplayAll()
1047 self.failUnless(presubmit.OutputApi.PresubmitError('').IsFatal()) 1047 self.failUnless(presubmit.OutputApi.PresubmitError('').IsFatal())
1048 self.failUnless(presubmit.OutputApi.PresubmitError('').IsMessage())
1048 self.failIf(presubmit.OutputApi.PresubmitError('').ShouldPrompt()) 1049 self.failIf(presubmit.OutputApi.PresubmitError('').ShouldPrompt())
1049 1050
1050 self.failIf(presubmit.OutputApi.PresubmitPromptWarning('').IsFatal()) 1051 self.failIf(presubmit.OutputApi.PresubmitPromptWarning('').IsFatal())
1051 self.failUnless( 1052 self.failUnless(
1052 presubmit.OutputApi.PresubmitPromptWarning('').ShouldPrompt()) 1053 presubmit.OutputApi.PresubmitPromptWarning('').ShouldPrompt())
1054 self.failUnless(
1055 presubmit.OutputApi.PresubmitPromptWarning('').IsMessage())
1053 1056
1054 self.failIf(presubmit.OutputApi.PresubmitNotifyResult('').IsFatal()) 1057 self.failIf(presubmit.OutputApi.PresubmitNotifyResult('').IsFatal())
1055 self.failIf(presubmit.OutputApi.PresubmitNotifyResult('').ShouldPrompt()) 1058 self.failIf(presubmit.OutputApi.PresubmitNotifyResult('').ShouldPrompt())
1059 self.failUnless(
1060 presubmit.OutputApi.PresubmitNotifyResult('foo').IsMessage())
1056 1061
1057 self.failIf(presubmit.OutputApi.PresubmitAddText('foo').IsFatal()) 1062 self.failIf(presubmit.OutputApi.PresubmitAddText('foo').IsFatal())
1058 self.failIf(presubmit.OutputApi.PresubmitAddText('foo').ShouldPrompt()) 1063 self.failIf(presubmit.OutputApi.PresubmitAddText('foo').ShouldPrompt())
1064 self.failIf(presubmit.OutputApi.PresubmitAddText('foo').IsMessage())
1059 1065
1060 # TODO(joi) Test MailTextResult once implemented. 1066 # TODO(joi) Test MailTextResult once implemented.
1061 1067
1062 def testOutputApiHandling(self): 1068 def testOutputApiHandling(self):
1063 self.mox.ReplayAll() 1069 self.mox.ReplayAll()
1064 1070
1065 output = StringIO.StringIO() 1071 output = StringIO.StringIO()
1066 unused_input = StringIO.StringIO() 1072 unused_input = StringIO.StringIO()
1067 added_text = presubmit.OutputApi.PresubmitAddText('R=ben@example.com') 1073 added_text = presubmit.OutputApi.PresubmitAddText('R=ben@example.com')
1068 self.failUnless(added_text._Handle(output, unused_input)) 1074 self.failUnless(added_text._Handle(output, unused_input))
(...skipping 832 matching lines...) Expand 10 before | Expand all | Expand 10 after
1901 def testCannedCheckOwners_CommittingWithLGTMs(self): 1907 def testCannedCheckOwners_CommittingWithLGTMs(self):
1902 self.OwnersTest(is_committing=True, 1908 self.OwnersTest(is_committing=True,
1903 approvers=set('ben@example.com'), 1909 approvers=set('ben@example.com'),
1904 uncovered_files=set(), 1910 uncovered_files=set(),
1905 expected_results=[]) 1911 expected_results=[])
1906 1912
1907 1913
1908 if __name__ == '__main__': 1914 if __name__ == '__main__':
1909 import unittest 1915 import unittest
1910 unittest.main() 1916 unittest.main()
OLDNEW
« presubmit_support.py ('K') | « presubmit_support.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698