suppress messages for PresubmitAddText results

presubmit_support.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.3.5'
 
@@ skipping 136 matching lines @@
     def IsFatal(self):
       """An error that is fatal stops g4 mail/submit immediately, i.e. before
       other presubmit scripts are run.
       """
       return False
 
     def ShouldPrompt(self):
       """Whether this presubmit result should result in a prompt warning."""
       return False
 
+    def IsMessage(self):

[M-A Ruel, 2011/03/10 13:41:44]

I'm wondering;

this should have all been properties instead, so for instance you set a class
member
is_message = True

and just set is_message = False in PresubmitAddText. But that would make it
different from the rest of the code, which wouldn't be nice.

+      """Whether this result contains anything needing to be displayed."""
+      return True
+
   class PresubmitAddText(PresubmitResult):
     """Propagates a line of text back to the caller."""
     def __init__(self, message, items=None, long_text=''):
       super(OutputApi.PresubmitAddText, self).__init__("ADD: " + message,
           items, long_text)
 
+    def IsMessage(self):
+      return False
+
   class PresubmitError(PresubmitResult):
     """A hard presubmit error."""
     def IsFatal(self):
       return True
 
   class PresubmitPromptWarning(PresubmitResult):
     """An warning that prompts the user if they want to continue."""
     def ShouldPrompt(self):
       return True
 
@@ skipping 876 matching lines @@
     else:
       errors.append(result)
 
   error_count = 0
   for name, items in (('Messages', notifications),
                       ('Warnings', warnings),
                       ('ERRORS', errors)):
     if items:
       output_stream.write('** Presubmit %s **\n' % name)
       for item in items:
+        if not item.IsMessage():
+          continue
+
         # Access to a protected member XXX of a client class
         # pylint: disable=W0212
         if not item._Handle(output_stream, input_stream,
                             may_prompt=False):
           error_count += 1
         output_stream.write('\n')
 
   total_time = time.time() - start_time
   if total_time > 1.0:
     print "Presubmit checks took %.1fs to calculate." % total_time
@@ skipping 105 matching lines @@
                                options.commit,
                                options.verbose,
                                sys.stdout,
                                sys.stdin,
                                options.default_presubmit,
                                options.may_prompt)
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))