suppress messages for PresubmitAddText results

suppress messages for PresubmitAddText results

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77700

[M-A Ruel, 2011-03-10 13:41:44]

lgtm with interrogations about life and everything.

http://codereview.chromium.org/6646040/diff/1/presubmit_support.py
File presubmit_support.py (right):

http://codereview.chromium.org/6646040/diff/1/presubmit_support.py#newcode157
presubmit_support.py:157: def IsMessage(self):
I'm wondering;

this should have all been properties instead, so for instance you set a class
member
is_message = True

and just set is_message = False in PresubmitAddText. But that would make it
different from the rest of the code, which wouldn't be nice.

[Dirk Pranke, 2011-03-10 19:31:28]

Yeah, it's kind of a toss-up. I'll leave it as-is for now.

-- Dirk

On Thu, Mar 10, 2011 at 5:41 AM,  <maruel@chromium.org> wrote:
> lgtm with interrogations about life and everything.
>
>
>
>
> http://codereview.chromium.org/6646040/diff/1/presubmit_support.py
> File presubmit_support.py (right):
>
> http://codereview.chromium.org/6646040/diff/1/presubmit_support.py#newcode157
> presubmit_support.py:157: def IsMessage(self):
> I'm wondering;
>
> this should have all been properties instead, so for instance you set a
> class member
> is_message = True
>
> and just set is_message = False in PresubmitAddText. But that would make
> it different from the rest of the code, which wouldn't be nice.
>
> http://codereview.chromium.org/6646040/
>