Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 6646037: autotest: fix DBusCalls flakiness (Closed)

Created:
9 years, 9 months ago by kmixter1
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli
Visibility:
Public.

Description

autotest: fix DBusCalls flakiness Previously was logging in and out and in immediate upon starting the test and the logouts were failing. Change-Id: I3440dc7c9a88949de657a8df0f4b5f0db8f8baca BUG=chromium-os:11272 TEST=Same Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7fcb38f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M client/site_tests/login_DBusCalls/login_DBusCalls.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
kmixter1
9 years, 9 months ago (2011-03-10 03:19:29 UTC) #1
Chris Masone
9 years, 9 months ago (2011-03-10 03:42:23 UTC) #2
LGTM

On Wed, Mar 9, 2011 at 7:19 PM, <kmixter@chromium.org> wrote:

> Reviewers: Chris Masone, dalec,
>
> Description:
> autotest: fix DBusCalls flakiness
>
> Previously was logging in and out and in immediate upon starting the test
> and
> the logouts were failing.
>
> Change-Id: I3440dc7c9a88949de657a8df0f4b5f0db8f8baca
>
> BUG=chromium-os:11272
> TEST=Same
>
> Please review this at http://codereview.chromium.org/6646037/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/autotest.git@master
>
> Affected files:
>  M client/site_tests/login_DBusCalls/login_DBusCalls.py
>
>
> Index: client/site_tests/login_DBusCalls/login_DBusCalls.py
> diff --git a/client/site_tests/login_DBusCalls/login_DBusCalls.py
> b/client/site_tests/login_DBusCalls/login_DBusCalls.py
> index
>
3c7a5765ce0f953e1652be99d48ae59c5522fdba..fbe235316c62b272b72c6f29fe0d864b2c3dc308
> 100644
> --- a/client/site_tests/login_DBusCalls/login_DBusCalls.py
> +++ b/client/site_tests/login_DBusCalls/login_DBusCalls.py
> @@ -7,6 +7,7 @@ from autotest_lib.client.bin import utils
>  from autotest_lib.client.common_lib import error
>  from autotest_lib.client.cros import constants as chromeos_constants
>  from autotest_lib.client.cros import cros_logging, cros_ui_test
> +from autotest_lib.client.cros import login
>
>  _SESSION_MANAGER_DEST='org.chromium.SessionManager'
>  _SESSION_MANAGER_OBJECT='org.chromium.SessionManagerInterface'
> @@ -68,5 +69,5 @@ class login_DBusCalls(cros_ui_test.UITest):
>
>
>     def run_once(self):
> -        self.login()
> +        login.wait_for_cryptohome()
>         self._test_restart_entd()
>
>
>

Powered by Google App Engine
This is Rietveld 408576698