Issue 6646022: Remove `sfi' abbreviations (a follow-up to r6902).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6646022: Remove `sfi' abbreviations (a follow-up to r6902). (Closed)

Created:
9 years, 9 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Remove `sfi' abbreviations (a follow-up to r6902). BUG=none TEST=none Committed revision: http://code.google.com/p/v8/source/detail?r=7124

Patch Set 1 #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -42 lines)			Patch
M	src/cpu-profiler.h	View	6 chunks	+10 lines, -10 lines	2 comments	Download
M	src/cpu-profiler.cc	View	7 chunks	+10 lines, -10 lines	0 comments	Download
M	src/cpu-profiler-inl.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/log.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/log.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mark-compact.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/profile-generator.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/profile-generator.cc	View	2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

LGTM http://codereview.chromium.org/6646022/diff/1/src/cpu-profiler.h File src/cpu-profiler.h (right): http://codereview.chromium.org/6646022/diff/1/src/cpu-profiler.h#newcode161 src/cpu-profiler.h:161: void SharedFunctionMoveEvent(Address from, Address to); Let's make it ...

9 years, 9 months ago (2011-03-09 19:22:24 UTC) #2

mnaganov (inactive)

9 years, 9 months ago (2011-03-10 12:02:03 UTC) #3

http://codereview.chromium.org/6646022/diff/1/src/cpu-profiler.h
File src/cpu-profiler.h (right):

http://codereview.chromium.org/6646022/diff/1/src/cpu-profiler.h#newcode161
src/cpu-profiler.h:161: void SharedFunctionMoveEvent(Address from, Address to);
On 2011/03/09 19:22:24, Vitaly Repeshko wrote:
> Let's make it "SharedFunctionInfoMoveEvent" to avoid any ambiguities in the
> interface.

Done.

Expand Messages | Collapse Messages