Issue 6646017: Rebuild scope chain from serialized scope info before parsing lazily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6646017: Rebuild scope chain from serialized scope info before parsing lazily. (Closed)

Created:
9 years, 9 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Rebuild scope chain from serialized scope info before parsing lazily. We used to rebuild it in Scope::Analyze but this might lead to mismatch between scopes seen by parser during the first and the second parse of the function. BUG=v8:1230 Committed: http://code.google.com/p/v8/source/detail?r=7110

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -43 lines)			Patch
M	src/parser.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/parser.cc	View	4 chunks	+17 lines, -13 lines	0 comments	Download
M	src/scopes.h	View	3 chunks	+10 lines, -8 lines	0 comments	Download
M	src/scopes.cc	View	2 chunks	+31 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages