leverage flashrom fast partial read function to speed up VPD read.

lib/fmap.c

 /* Copyright 2010, Google Inc.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *    * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *    * Redistributions in binary form must reproduce the above
@@ skipping 34 matching lines @@
 #include <inttypes.h>
 
 #include "lib/lib_vpd.h"
 #include "lib/fmap.h"
 
 
 void fmapNormalizeAreaName(uint8_t *name) {
   assert(name);
 
   while (*name) {
-    if (!(isascii(*name) && isalnum(*name))) {
+    if (!(isascii(*name) && (isalnum(*name) || *name == ' '))) {

[dhendrix, 2011/03/10 01:33:51]

Is isascii() required if isalnum() used?

[Louis, 2011/03/10 08:22:51]

I think isalnum() is locale-dependent implementation. According to the manpage,
there may be additional characters in some locales.


       isalnum()
              checks for an alphanumeric character; it is equivalent to (isal‐
              pha(c) || isdigit(c)).

       isalpha()
              checks for an alphabetic character; in the standard "C"  locale,
              it  is  equivalent  to  (isupper(c)  ||  islower(c)).   In  some
              locales, there may be additional characters for which  isalpha()
              is true—letters which are neither upper case nor lower case.




On 2011/03/10 01:33:51, dhendrix wrote:

       *name = '_';
     }
     name++;
   }
 }
 
 off_t fmapFind(const uint8_t *image, size_t image_len) {
   off_t offset;
   uint64_t sig;
 
@@ skipping 31 matching lines @@
   for (i = 0; i < fmap->nareas; i++) {
     if (0 == strcmp(fmap->areas[i].name, name)) {
       *offset = fmap->areas[i].offset;
       *size = fmap->areas[i].size;
       return FMAP_OK;
     }
   }
 
   return FMAP_FAIL;
 }