presubmit_canned_checks.py - Issue 6646009: update git-cl for OWNERS file support via .git/hooks/pre-cl-*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 6646009: update git-cl for OWNERS file support via .git/hooks/pre-cl-* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: clean up after running owners-related git-cl tests Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 77827054ee803e8b10b82d5c6f6804cff701a190..40df31a59d60bb2bd9f5006f3cf9641652456f0d 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -634,7 +634,7 @@ def CheckOwners(input_api, output_api, email_regexp=None,

if email_regexp:

owners_db.email_regexp = input_api.re.compile(email_regexp)

- if input_api.is_committing and input_api.is_tbr:

+ if input_api.is_committing and input_api.tbr:

return [output_api.PresubmitNotifyResult(

'--tbr was specified, skipping OWNERS check')]

elif input_api.is_committing:

« no previous file with comments | « git_cl_hooks.py ('k') | presubmit_support.py » ('j') | no next file with comments »