Creates the ipclist utility that chrome security team has wanted to dump...

Creates the ipclist utility that chrome security team has wanted to dump
the known IPC messages.  Going forward, this should help identify new messages
between versions of chrome so that they may be given extra scrutiny for 
potential badness.


under the common_message_generator.h umbrella.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78564

[Tom Sepez, 2011-03-08 22:55:02]

The first tangible benefit from having message generators.  Justin, this is the
message listing utility you asked for the other day.

[jam, 2011-03-09 06:33:45]

lgtm

http://codereview.chromium.org/6646005/diff/1/chrome/common/gpu_messages.h
File chrome/common/gpu_messages.h (right):

http://codereview.chromium.org/6646005/diff/1/chrome/common/gpu_messages.h#ne...
chrome/common/gpu_messages.h:34: namespace gfx {
nit: looks like these four forward declarations aren't needed since their
headers are included

http://codereview.chromium.org/6646005/diff/1/chrome/common/gpu_messages.h#ne...
chrome/common/gpu_messages.h:404: 
nit: extra line

http://codereview.chromium.org/6646005/diff/1/chrome/common/render_messages.h
File chrome/common/render_messages.h (right):

http://codereview.chromium.org/6646005/diff/1/chrome/common/render_messages.h...
chrome/common/render_messages.h:83: #if defined(OS_MACOSX)
nit: can take out all the forward declarations in this file

http://codereview.chromium.org/6646005/diff/1/chrome/test/ipclist/ipclist.cc
File chrome/test/ipclist/ipclist.cc (right):

http://codereview.chromium.org/6646005/diff/1/chrome/test/ipclist/ipclist.cc#...
chrome/test/ipclist/ipclist.cc:1: 
nit: empty line

http://codereview.chromium.org/6646005/diff/1/chrome/test/ipclist/ipclist.cc#...
chrome/test/ipclist/ipclist.cc:31: if (std::string("--args") == *argv)
nit: need brace brackets for if statement per guidelines, also below in the for
loop

[Paweł Hajdan Jr., 2011-03-09 15:56:40]

Drive-by with a "test" comment for a surprisingly non-test change (or so it
seems). No need to wait for me whatever you decide to do.

http://codereview.chromium.org/6646005/diff/1/chrome/test/ipclist/ipclist.cc
File chrome/test/ipclist/ipclist.cc (right):

http://codereview.chromium.org/6646005/diff/1/chrome/test/ipclist/ipclist.cc#...
chrome/test/ipclist/ipclist.cc:4: 
I think you really want this file in chrome/tools. chrome/test is already
crowded and messy.

[Tom Sepez, 2011-03-10 01:03:46]

Hi John,

Pls take a look at this latest revision.  Trying to solve the linking issue
introduced lumping the messages together in the common .cc files.  Here's an
approach to avoid having to duplicate all the generator logic in every cc file
that we introduce. 

See ipc/ipc_message_generator.h, ipc/all_messages.h, and say,
common_message_generator.cc.  I expect you will hate this :).  The question is
whether you hate it less than the approach of having all these cc files
containing the code that appears in ipc_message_generator.h.

[Tom Sepez, 2011-03-10 21:17:37]

Ha. It builds again on windows.  Needs review.

[Tom Sepez, 2011-03-16 19:00:03]

Hi John,

Much smaller version that I'd like to check in, now that the message files have
been (mostly) converted in earlier CLs. 

Is there someone who could check out the new target in chrome.gyp?  I know I'm
missing a msvs identifier.  Is that needed?

The message.h files are changes to clean up punctuation and/or multiple
inclusion issues.

Added a comment to ipc_message_macros about those stray ;'s.

[jam, 2011-03-16 20:30:26]

lgtm

I don't know if the msvs_guid thing is needed for exe's or just static libs. 
ccing bradnelson who will know

[bradn, 2011-03-17 18:00:04]

So historically these were needed because the release folks used knowledge of
particular GUIDS to strip the .slns before release builds.

HOWEVER, I just learned that nsylvain (woot woot!) changed their scripts about
3-4 weeks ago to use gyp targets instead. Which means we should now be able to
drop ALL the msvs_guids!!!

So please don't add a guid and if you're touching a gyp file, please drop the
other guids too.

[Tom Sepez, 2011-03-17 18:33:53]

Woot.  I didn't drop the other guids however, feels like this should go into its
own CL.