Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Side by Side Diff: chrome/browser/resources/collected_cookies.js

Issue 6644002: [ChromeOS] Implement collected cookies in webui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync, address evan and oshima's comemnts #1 Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 function closeDialog() {
6 chrome.send('DialogClose', ['']);
7 }
8
9 function setInfobarLabel(text) {
10 $('info-banner').textContent = text;
11 $('info-banner').hidden = !text.length;
12 }
13
14 function updateControlState() {
15 var allowedCookies = $('allowed-cookies');
16 $('block-button').disabled = !allowedCookies.children.length ||
17 !allowedCookies.selectedItem ||
18 allowedCookies.selectedItem.data.type != 'origin';
19
20 var blockedCookies = $('blocked-cookies');
21 $('allow-button').disabled =
22 $('allow-this-session-button').disabled = !blockedCookies.children.length ||
23 !blockedCookies.selectedItem ||
24 blockedCookies.selectedItem.data.type != 'origin';;
arv (Not doing code reviews) 2011/03/10 18:03:00 too many semicolons
xiyuan 2011/03/10 19:23:59 Done.
25 }
26
27 function handleCookiesTreeChange(e) {
28 updateControlState();
29 }
30
31 function handleBlockButtonClick(e) {
32 var selected = $('allowed-cookies').selectedItem;
33 if (!selected)
arv (Not doing code reviews) 2011/03/10 18:03:00 negate and remove return?
xiyuan 2011/03/10 19:23:59 Done.
34 return;
35
36 chrome.send('Block', [selected.pathId]);
37 }
38
39 function handleAllowButtonClick(e) {
40 var selected = $('blocked-cookies').selectedItem;
41 if (!selected)
42 return;
43
44 chrome.send('Allow', [selected.pathId]);
45 }
46
47 function handleAllowThisSessionButtonClick(e) {
48 var selected = $('blocked-cookies').selectedItem;
49 if (!selected)
50 return;
51
52 chrome.send('AllowThisSession', [selected.pathId]);
53 }
54
55 window.onkeydown = function(e) {
arv (Not doing code reviews) 2011/03/10 18:03:00 document.onkeydown
xiyuan 2011/03/10 19:23:59 Done. And moved it into load().
56 if (e.keyCode == 27) // Esc
57 closeDialog();
58 }
59
60 function load() {
61 ui.CookiesTree.decorate($('allowed-cookies'));
62 ui.CookiesTree.decorate($('blocked-cookies'));
63
64 chrome.send('BindCookiesTreeModel', []);
65
66 $('allowed-cookies').addEventListener('change', handleCookiesTreeChange);
67 $('blocked-cookies').addEventListener('change', handleCookiesTreeChange);
68
69 $('block-button').addEventListener('click', handleBlockButtonClick);
70 $('allow-button').addEventListener('click', handleAllowButtonClick);
71 $('allow-this-session-button').addEventListener('click',
72 handleAllowThisSessionButtonClick);
73
74 $('close-button').addEventListener('click', function(e) {
arv (Not doing code reviews) 2011/03/10 18:03:00 $('close-button').addEventListener('click', closeD
xiyuan 2011/03/10 19:23:59 Done.
75 closeDialog();
76 });
77
78 cr.defineProperty($('info-banner'), 'hidden', cr.PropertyKind.BOOL_ATTR);
arv (Not doing code reviews) 2011/03/10 18:03:00 You don't need this line. hidden is already availa
xiyuan 2011/03/10 19:23:59 Removed.
79
80 updateControlState();
81 }
82
83 document.addEventListener('DOMContentLoaded', load);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698