Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 function closeDialog() { | |
|
arv (Not doing code reviews)
2011/03/09 18:42:47
Copyright header
xiyuan
2011/03/09 21:33:31
Done.
| |
| 2 chrome.send('DialogClose', ['']); | |
|
arv (Not doing code reviews)
2011/03/09 18:42:47
Pass empty array instead?
arv (Not doing code reviews)
2011/03/09 18:42:47
dialogClose for consistency with the rest of the c
xiyuan
2011/03/09 21:33:31
'DialogClose' is a HTML dialog close message that
xiyuan
2011/03/09 21:33:31
Could not unless we change the underlying Constrai
| |
| 3 } | |
| 4 | |
| 5 function setInfobarLabel(text) { | |
| 6 $('info-text').textContent = text; | |
| 7 | |
| 8 if (text.length) { | |
|
arv (Not doing code reviews)
2011/03/09 18:42:47
$('info-banner').hidden = text.length;
xiyuan
2011/03/09 21:33:31
Done.
| |
| 9 $('info-banner').classList.remove('hidden'); | |
| 10 } else { | |
| 11 $('info-banner').classList.add('hidden'); | |
| 12 } | |
| 13 } | |
| 14 | |
| 15 function updateControlState() { | |
| 16 var allowedCookies = $('allowedCookies'); | |
| 17 $('blockButton').disabled = !allowedCookies.children.length || | |
| 18 !allowedCookies.selectedItem || | |
| 19 allowedCookies.selectedItem.data.type != 'origin'; | |
| 20 | |
| 21 var blockedCookies = $('blockedCookies'); | |
| 22 $('allowButton').disabled = | |
| 23 $('allowThisSessionButton').disabled = !blockedCookies.children.length || | |
| 24 !blockedCookies.selectedItem || | |
| 25 blockedCookies.selectedItem.data.type != 'origin';; | |
| 26 } | |
| 27 | |
| 28 function handleCookiesTreeChange(e) { | |
| 29 updateControlState(); | |
| 30 } | |
| 31 | |
| 32 function handleBlockButtonClick(e) { | |
| 33 var selected = $('allowedCookies').selectedItem; | |
| 34 if (!selected) | |
| 35 return; | |
| 36 | |
| 37 chrome.send('block', [selected.pathId]); | |
| 38 } | |
| 39 | |
| 40 function handleAllowButtonClick(e) { | |
| 41 var selected = $('blockedCookies').selectedItem; | |
| 42 if (!selected) | |
| 43 return; | |
| 44 | |
| 45 chrome.send('allow', [selected.pathId]); | |
| 46 } | |
| 47 | |
| 48 function handleAllowThisSessionButtonClick(e) { | |
| 49 var selected = $('blockedCookies').selectedItem; | |
| 50 if (!selected) | |
| 51 return; | |
| 52 | |
| 53 chrome.send('allowThisSession', [selected.pathId]); | |
| 54 } | |
| 55 | |
| 56 window.onkeydown = function(e) { | |
| 57 if (e.keyCode == 27) | |
|
arv (Not doing code reviews)
2011/03/09 18:42:47
Use keyIdentifier or add a comment what 27 is for
xiyuan
2011/03/09 21:33:31
Comment added. keyIdentifier for ESC is 'U+001B'.
| |
| 58 closeDialog(); | |
| 59 } | |
| 60 | |
| 61 function load() { | |
| 62 ui.CookiesTree.decorate($('allowedCookies')); | |
| 63 ui.CookiesTree.decorate($('blockedCookies')); | |
| 64 | |
| 65 chrome.send('bindCookiesTreeModel', []); | |
| 66 | |
| 67 $('allowedCookies').addEventListener('change', handleCookiesTreeChange); | |
| 68 $('blockedCookies').addEventListener('change', handleCookiesTreeChange); | |
| 69 | |
| 70 $('blockButton').addEventListener('click', handleBlockButtonClick); | |
| 71 $('allowButton').addEventListener('click', handleAllowButtonClick); | |
| 72 $('allowThisSessionButton').addEventListener('click', | |
| 73 handleAllowThisSessionButtonClick); | |
| 74 | |
| 75 updateControlState(); | |
| 76 } | |
| 77 | |
| 78 document.addEventListener('DOMContentLoaded', load); | |
| OLD | NEW |