chrome/browser/resources/collected_cookies.html - Issue 6644002: [ChromeOS] Implement collected cookies in webui.

Side by Side Diff: chrome/browser/resources/collected_cookies.html

Issue 6644002: [ChromeOS] Implement collected cookies in webui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: exclude for non-chromeos build Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/collected_cookies.css ('K') | « chrome/browser/resources/collected_cookies.css ('k') | chrome/browser/resources/collected_cookies.js » ('j') | chrome/browser/resources/collected_cookies.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html i18n-values="dir:textdirection;">

	3

	4 <head>

	5 <meta charset="utf-8">

	6 <title i18n-content="title"></title>

	7 <link rel="stylesheet" href="chrome://resources/css/tree.css">

	8 <link rel="stylesheet" href="collected_cookies.css">

	9 </head>

	10

	11 <script src="chrome://resources/css/tree.css.js"></script>

	12

	13 <script src="chrome://resources/js/cr.js"></script>

	14 <script src="chrome://resources/js/cr/ui.js"></script>

	15 <script src="chrome://resources/js/cr/ui/tree.js"></script>

	16 <script src="chrome://resources/js/util.js"></script>

	17 <script src="cookies_tree.js"></script>

	18 <script src="collected_cookies.js"></script>

	19

	20 <body>

	21

	22 <div id="info-banner" class="hidden">
	arv (Not doing code reviews) 2011/03/09 18:42:47 <hx> maybe? <hx> maybe? xiyuan 2011/03/09 21:33:31 <hx>'s before and after space seems to be too much Show quoted text On 2011/03/09 18:42:47, arv wrote: > <hx> maybe? <hx>'s before and after space seems to be too much. arv (Not doing code reviews) 2011/03/10 18:03:00 That should be fixed with css margins. In general Show quoted text On 2011/03/09 21:33:31, xiyuan wrote: > On 2011/03/09 18:42:47, arv wrote: > > <hx> maybe? > > <hx>'s before and after space seems to be too much. That should be fixed with css margins. In general it is better to use the more semantically correct elements
	23 <span id="info-text"></span>
	arv (Not doing code reviews) 2011/03/09 18:42:47 Do you need the span here? Do you need the span here? xiyuan 2011/03/09 21:33:31 Removed. Show quoted text On 2011/03/09 18:42:47, arv wrote: > Do you need the span here? Removed.
	24 </div>

	25

	26 <div i18n-content="allowedCookies"></div>
	arv (Not doing code reviews) 2011/03/09 18:42:47 p, hx? p, hx? xiyuan 2011/03/09 21:33:31 <p> used. Show quoted text On 2011/03/09 18:42:47, arv wrote: > p, hx? <p> used.
	27 <tree id="allowedCookies" class="cookies-tree"></tree>
	arv (Not doing code reviews) 2011/03/09 18:42:47 id="allowed-cookies" id="allowed-cookies" xiyuan 2011/03/09 21:33:31 Done. Show quoted text On 2011/03/09 18:42:47, arv wrote: > id="allowed-cookies" Done.
	28 <button id="blockButton" i18n-content="blockButton"></button>

	29

	30 <div i18n-content="blockedCookies"></div>

	31 <tree id="blockedCookies" class="cookies-tree"></tree>

	32 <button id="allowButton" i18n-content="allowButton"></button>

	33 <button id="allowThisSessionButton"

	34 i18n-content="allowThisSessionButton"></button>

	35 <button onclick="closeDialog();">Close Me</button>
	arv (Not doing code reviews) 2011/03/09 18:42:47 i18n? i18n? arv (Not doing code reviews) 2011/03/09 18:42:47 move this onclick to js as well? move this onclick to js as well? xiyuan 2011/03/09 21:33:31 Oops. Forgot to update this. Fixed now. Show quoted text On 2011/03/09 18:42:47, arv wrote: > i18n? Oops. Forgot to update this. Fixed now. xiyuan 2011/03/09 21:33:31 Done. Show quoted text On 2011/03/09 18:42:47, arv wrote: > move this onclick to js as well? Done.
	36 </body>

	37 </html>

OLD	NEW