Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/frames.cc

Issue 6635042: Remove GetProvidedParametersCount from JavaScriptFrame, it simply calls Compu... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/frames.h ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 612 matching lines...) Expand 10 before | Expand all | Expand 10 after
623 return IsConstructFrame(fp); 623 return IsConstructFrame(fp);
624 } 624 }
625 625
626 626
627 Code* JavaScriptFrame::unchecked_code() const { 627 Code* JavaScriptFrame::unchecked_code() const {
628 JSFunction* function = JSFunction::cast(this->function()); 628 JSFunction* function = JSFunction::cast(this->function());
629 return function->unchecked_code(); 629 return function->unchecked_code();
630 } 630 }
631 631
632 632
633 int JavaScriptFrame::GetProvidedParametersCount() const {
634 return ComputeParametersCount();
635 }
636
637
638 Address JavaScriptFrame::GetCallerStackPointer() const { 633 Address JavaScriptFrame::GetCallerStackPointer() const {
639 int arguments; 634 int arguments;
640 if (Heap::gc_state() != Heap::NOT_IN_GC || 635 if (Heap::gc_state() != Heap::NOT_IN_GC ||
641 SafeStackFrameIterator::is_active()) { 636 SafeStackFrameIterator::is_active()) {
642 // If the we are currently iterating the safe stack the 637 // If the we are currently iterating the safe stack the
643 // arguments for frames are traversed as if they were 638 // arguments for frames are traversed as if they were
644 // expression stack elements of the calling frame. The reason for 639 // expression stack elements of the calling frame. The reason for
645 // this rather strange decision is that we cannot access the 640 // this rather strange decision is that we cannot access the
646 // function during mark-compact GCs when objects may have been marked. 641 // function during mark-compact GCs when objects may have been marked.
647 // In fact accessing heap objects (like function->shared() below) 642 // In fact accessing heap objects (like function->shared() below)
(...skipping 575 matching lines...) Expand 10 before | Expand all | Expand 10 after
1223 ZoneList<StackFrame*> list(10); 1218 ZoneList<StackFrame*> list(10);
1224 for (StackFrameIterator it; !it.done(); it.Advance()) { 1219 for (StackFrameIterator it; !it.done(); it.Advance()) {
1225 StackFrame* frame = AllocateFrameCopy(it.frame()); 1220 StackFrame* frame = AllocateFrameCopy(it.frame());
1226 list.Add(frame); 1221 list.Add(frame);
1227 } 1222 }
1228 return list.ToVector(); 1223 return list.ToVector();
1229 } 1224 }
1230 1225
1231 1226
1232 } } // namespace v8::internal 1227 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/frames.h ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698