Issue 6635041: Fix bug in X64 RegExpExec stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6635041: Fix bug in X64 RegExpExec stub. (Closed)

Created:
9 years, 9 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix bug in X64 RegExpExec stub. Used incorrect register for referencing RegExp data, so it always failed to match the fast case. When modifiying the object layout, it was possible to make it crash instead. BUG=v8:1236 TEST=test/mjsunit/regress/regress-1236.js Committed: http://code.google.com/p/v8/source/detail?r=7091

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -18 lines)			Patch
M	src/jsregexp.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	3 chunks	+9 lines, -10 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+6 lines, -7 lines	0 comments	Download
A	test/mjsunit/regress/regress-1236.js	View	1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages