Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 6634003: This change fixes the platform_KernelErrorCodePaths test so that it (Closed)

Created:
9 years, 9 months ago by thutt
Modified:
9 years, 5 months ago
Visibility:
Public.

Description

This change fixes the platform_KernelErrorCodePaths test so that it does not hang on Tegra2 systems. On those systems, there is no 'preserved memory' support, so the sysctl settings to cause an immediate reboot are not set. The result now is that the test will fail (rather than hang) on Tegra2 boards. It completes successfully on Mario machines. Change-Id: Id5cf4ff3f0e08bb29bed8dcbdac717f93c9b3a9d BUG= TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b23a645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M server/site_tests/platform_KernelErrorPaths/platform_KernelErrorPaths.py View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
thutt
Anyone have a chance to look at this trivial change?
9 years, 9 months ago (2011-03-11 21:30:04 UTC) #1
sjg
9 years, 9 months ago (2011-03-14 18:55:32 UTC) #2
On 2011/03/11 21:30:04, thutt wrote:
> Anyone have a chance to look at this trivial change?

Sorry I am so late. This is fine as a temporary but it should probably go away
with preserved finally lands. Perhaps a TODO(thutt) to remove it later?

Powered by Google App Engine
This is Rietveld 408576698