Issue 6634001: WiFi load testing has connection flakiness. Increase retries to 3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6634001: WiFi load testing has connection flakiness. Increase retries to 3. (Closed)

Created:
9 years, 9 months ago by DaleCurtis

Modified:
9 years, 7 months ago

Reviewers:
ericli

CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli

Base URL:
ssh://git@gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

WiFi load testing has connection flakiness. Increase retries to 3. Change-Id: Ic035461f086f038c7ddc98311b8a436f5c138008 BUG=n0ne TEST=Ran run_remote_tests, but will need to see in live environment. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6e6be98

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	client/site_tests/power_LoadTest/power_LoadTest.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ericli

9 years, 9 months ago (2011-03-04 23:03:48 UTC) #2

LGTM.

On Fri, Mar 4, 2011 at 3:01 PM, <dalecurtis@chromium.org> wrote:

> Reviewers: ericli,
>
> Description:
> WiFi load testing has connection flakiness. Increase retries to 3.
>
> Change-Id: Ic035461f086f038c7ddc98311b8a436f5c138008
>
> BUG=
> TEST=Ran run_remote_tests, but will need to see in live environment.
>
> Please review this at http://codereview.chromium.org/6634001/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/autotest.git@master
>
> Affected files:
>  M client/site_tests/power_LoadTest/power_LoadTest.py
>
>
> Index: client/site_tests/power_LoadTest/power_LoadTest.py
> diff --git a/client/site_tests/power_LoadTest/power_LoadTest.py
> b/client/site_tests/power_LoadTest/power_LoadTest.py
> index
>
af9cecc915280289d52f7a84eea8e3b4f445574a..93a9e1a73a9f025d878e2823bc07d82dc8e28c5f
> 100755
> --- a/client/site_tests/power_LoadTest/power_LoadTest.py
> +++ b/client/site_tests/power_LoadTest/power_LoadTest.py
> @@ -90,7 +90,8 @@ class power_LoadTest(cros_ui_test.UITest):
>             # take several tries for WiFi to connect. More experimentation
> with
>             # the retry settings here may be necessary if this becomes a
> source
>             # of test flakiness in the future.
> -            if not flimflam.FlimFlam().ConnectService(retry=True,
> +            if not flimflam.FlimFlam().ConnectService(retries=3,
> +                                                      retry=True,
>                                                       service_type='wifi',
>                                                       ssid=wifi_ap,
>                                                       security=wifi_sec,
>
>
>


-- 
Eric Li
李咏竹
Google Kirkland

Expand Messages | Collapse Messages