Re-enable chroot passthru for AU server environment variable override

Re-enable chroot passthru for AU server environment variable override

Change-Id: I9856fe64942d586281fee09dff15af9d8178b392

BUG=none
TEST=manual

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3b11b45

[gauravsh, 2011-03-05 02:14:34]

Drive-by nits...

nit: Issue description should say 'Re-enable, not Renabling'.
nit: Update BUG and TEST field. 'none' if no bug exists. TEST=manual/or whatever
procedure you followed to ensure your issue worked.

http://codereview.chromium.org/6633009/diff/1/enter_chroot.sh
File enter_chroot.sh (right):

http://codereview.chromium.org/6633009/diff/1/enter_chroot.sh#newcode358
enter_chroot.sh:358: # Set CHROMEOS_VERSION_TRACK, CHROMEOS_VERSION_AUSERVER,
CHROMEOS_VERSION_DEVSERVER as environment variables to override the default
assumptions (local AU server)
80 chars

http://codereview.chromium.org/6633009/diff/1/enter_chroot.sh#newcode360
enter_chroot.sh:360: CHROMEOS_VERSION_TRACK=$CHROMEOS_VERSION_TRACK
CHROMEOS_VERSION_AUSERVER=$CHROMEOS_VERSION_AUSERVER
CHROMEOS_VERSION_DEVSERVER=$CHROMEOS_VERSION_DEVSERVER"
80 chars

http://codereview.chromium.org/6633009/diff/1/enter_chroot.sh#newcode360
enter_chroot.sh:360: CHROMEOS_VERSION_TRACK=$CHROMEOS_VERSION_TRACK
CHROMEOS_VERSION_AUSERVER=$CHROMEOS_VERSION_AUSERVER
CHROMEOS_VERSION_DEVSERVER=$CHROMEOS_VERSION_DEVSERVER"
put { } around the $ bash vars inside the assignment string

[Liam McLoughlin, 2011-03-14 20:32:39]

Fixed the errors pointed out in your comment

[petkov, 2011-03-14 21:05:07]

http://codereview.chromium.org/6633009/diff/3001/enter_chroot.sh
File enter_chroot.sh (right):

http://codereview.chromium.org/6633009/diff/3001/enter_chroot.sh#newcode358
enter_chroot.sh:358: # Set CHROMEOS_VERSION_TRACK, CHROMEOS_VERSION_AUSERVER,
CHROMEOS_VERSION_DEVSERVER
80 chars.

Also, you might want to mention that these variables are used by external
Chromium OS builders (to avoid having them deleted in a future cleanup).

http://codereview.chromium.org/6633009/diff/3001/enter_chroot.sh#newcode359
enter_chroot.sh:359: # as environment variables to override the default
assumptions (local AU server)
refer to cros_set_lsb_release here.

[petkov, 2011-03-14 21:58:59]

A few more nits on this one.

http://codereview.chromium.org/6633009/diff/6001/enter_chroot.sh
File enter_chroot.sh (right):

http://codereview.chromium.org/6633009/diff/6001/enter_chroot.sh#newcode358
enter_chroot.sh:358: # Set CHROMEOS_VERSION_TRACK, CHROMEOS_VERSION_AUSERVER,
CHROMEOS_VERSION_DEVSERVER
80 chars

http://codereview.chromium.org/6633009/diff/6001/enter_chroot.sh#newcode361
enter_chroot.sh:361: # builders
periods at the end of the sentences.

[Liam McLoughlin, 2011-03-14 22:05:12]

All fixed. Would be cool if the git-cl tool checked for accidental 80+ chars
lines, might have to submit a patch for that.

On 2011/03/14 21:58:59, petkov wrote:
> A few more nits on this one.
> 
> http://codereview.chromium.org/6633009/diff/6001/enter_chroot.sh
> File enter_chroot.sh (right):
> 
> http://codereview.chromium.org/6633009/diff/6001/enter_chroot.sh#newcode358
> enter_chroot.sh:358: # Set CHROMEOS_VERSION_TRACK, CHROMEOS_VERSION_AUSERVER,
> CHROMEOS_VERSION_DEVSERVER
> 80 chars
> 
> http://codereview.chromium.org/6633009/diff/6001/enter_chroot.sh#newcode361
> enter_chroot.sh:361: # builders
> periods at the end of the sentences.

[petkov, 2011-03-14 22:11:21]

LGTM w/ one more nit.

Do you need me to push these for you?

http://codereview.chromium.org/6633009/diff/9001/enter_chroot.sh
File enter_chroot.sh (right):

http://codereview.chromium.org/6633009/diff/9001/enter_chroot.sh#newcode362
enter_chroot.sh:362: 
remove blank line

[Liam McLoughlin, 2011-03-14 22:28:29]

Removed it. Yep, need you to push for me please.

On 2011/03/14 22:11:21, petkov wrote:
> LGTM w/ one more nit.
> 
> Do you need me to push these for you?
> 
> http://codereview.chromium.org/6633009/diff/9001/enter_chroot.sh
> File enter_chroot.sh (right):
> 
> http://codereview.chromium.org/6633009/diff/9001/enter_chroot.sh#newcode362
> enter_chroot.sh:362: 
> remove blank line

[petkov, 2011-03-14 23:07:01]

Pushed...