Issue 6631003: Don't translate dirty rectangles in Mac capturer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6631003: Don't translate dirty rectangles in Mac capturer. (Closed)

Created:
9 years, 9 months ago by Lambros

Modified:
9 years, 7 months ago

Reviewers:
dmac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Don't translate dirty rectangles in Mac capturer. BUG=74809 TEST=Follow repro steps in bug report Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76939

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	remoting/host/capturer_mac.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lambros

This simple change fixes a crash I saw whilst testing the Mac host. It removes ...

9 years, 9 months ago (2011-03-04 17:17:48 UTC) #1

dmac

9 years, 9 months ago (2011-03-04 17:44:35 UTC) #2

LGTM. Originally was like that because bitmap was flipped. We now flip the
bitmap, so no need to reset the origin.

Expand Messages | Collapse Messages