Allow webdriver users to choose between sending the key events when...

chrome/browser/automation/testing_automation_provider.h

Index: chrome/browser/automation/testing_automation_provider.h
===================================================================
--- chrome/browser/automation/testing_automation_provider.h	(revision 78866)
+++ chrome/browser/automation/testing_automation_provider.h	(working copy)
@@ -9,6 +9,7 @@
 #include "base/basictypes.h"
 #include "base/scoped_ptr.h"
 #include "chrome/browser/automation/automation_provider.h"
+#include "chrome/browser/automation/automation_provider_json.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/importer/importer_list.h"
@@ -754,12 +755,11 @@
                            DictionaryValue* args,
                            IPC::Message* reply_message);
 
-  // Sends a web keyboard event to the active tab. This should not trigger any
-  // browser hotkeys.
-  // Uses the JSON interface for input/output.
-  void SendKeyEventToActiveTab(Browser* browser,
-                               DictionaryValue* args,
-                               IPC::Message* reply_message);
+  // Populates the fields of the event parameters with what is found
+  // on the args one.
+  bool BuildWebKeyEventFromArgs(DictionaryValue* args,
+                                IPC::Message* reply_message,
+                                NativeWebKeyboardEvent* event);
 
   // Determines whether each relevant section of the NTP is in thumbnail mode.
   void GetNTPThumbnailMode(Browser* browser,
@@ -959,6 +959,23 @@
   void SendWebkitKeyEvent(DictionaryValue* args,
                           IPC::Message* message);
 
+  // Sends the key event from the OS level to the browser window,
+  // allowing it to be preprocessed by some external application (ie. IME).
+  // Will switch to the tab specified by tab_index before sending the event.
+  // Example:
+  //   input: { "windex": 1,
+  //            "tab_index": 1,
+  //            "nativeKeyCode": ui::VKEY_X,
+  //            "windowsKeyCode": ui::VKEY_X,
+  //            "modifiers": automation::kShiftKeyMask,
+  //          }
+  //   output: none
+  void SendOSLevelKeyEvent(DictionaryValue* args,

[kkania, 2011/03/24 23:20:32]

this comment is out of date

[timothe, 2011/03/25 11:07:59]

Done.

+                           IPC::Message* message);
+
+  // Method used as a Task that sends a success AutomationJSONReply.
+  void SendSuccessReply(IPC::Message* reply_message);
+
   // Activates the given tab.
   // Example:
   //   input: { "windex": 1,