Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: chrome/browser/automation/testing_automation_provider.h

Issue 6630001: Allow webdriver users to choose between sending the key events when... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/testing_automation_provider.h
===================================================================
--- chrome/browser/automation/testing_automation_provider.h (revision 77600)
+++ chrome/browser/automation/testing_automation_provider.h (working copy)
@@ -754,13 +754,18 @@
DictionaryValue* args,
IPC::Message* reply_message);
- // Sends a web keyboard event to the active tab. This should not trigger any
- // browser hotkeys.
- // Uses the JSON interface for input/output.
- void SendKeyEventToActiveTab(Browser* browser,
- DictionaryValue* args,
- IPC::Message* reply_message);
+ // Populates the fields of the event parameters with what is found
+ // on the args one.
+ bool BuildNativeWebKeyEventFromArgs(DictionaryValue* args,
+ IPC::Message* reply_message,
+ NativeWebKeyboardEvent* event);
+ // Populates the fields of the event parameters with what is found
+ // on the args one.
+ bool BuildWebKeyEventFromArgs(DictionaryValue* args,
+ IPC::Message* reply_message,
+ NativeWebKeyboardEvent* event);
+
// Determines whether each relevant section of the NTP is in thumbnail mode.
void GetNTPThumbnailMode(Browser* browser,
DictionaryValue* args,
@@ -959,6 +964,20 @@
void SendWebkitKeyEvent(DictionaryValue* args,
IPC::Message* message);
+ // Sends the WebKit key event from the OS level to the browser window,
+ // allowing it to be preprocessed by some external application (ie. IME).
+ // Example:
+ // input: { "windex": 1,
+ // "tab_index": 1,
+ // "type": automation::kRawKeyDownType,
+ // "nativeKeyCode": ui::VKEY_X,
+ // "windowsKeyCode": ui::VKEY_X,
+ // "modifiers": automation::kShiftKeyMask,
+ // }
+ // output: none
+ void SendOSLevelKeyEvent(DictionaryValue* args,
+ IPC::Message* message);
+
// Activates the given tab.
// Example:
// input: { "windex": 1,

Powered by Google App Engine
This is Rietveld 408576698