Allow webdriver users to choose between sending the key events when...

chrome/test/webdriver/automation.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/webdriver/automation.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #endif
 
@@ skipping 222 matching lines @@
   dict.SetInteger("start_y", start.y());
   dict.SetInteger("end_x", end.x());
   dict.SetInteger("end_y", end.y());
 
   *success = SendJSONRequest(tab_id, dict, &reply);
   if (!*success) {
     LOG(ERROR) << "Could not send mouse event. Reply: " << reply;
   }
 }
 
 void Automation::SendWebKeyEvent(int tab_id,

[kkania, 2011/03/10 00:28:58]

I would prefer creating a separate method here for sending native events, since
they call two different commands and should have different arguments.

[timothe faudot, 2011/03/10 05:34:32]

Done. I created a SendNativeWebKeyEvent uses different json args (only those
necessary for the event to be handled in ui_controls::SendKeyPress)

                                  const WebKeyEvent& key_event,
+                                 bool use_native_events,
                                  bool* success) {
   std::string reply;
   DictionaryValue dict;
 
-  dict.SetString("command", "SendKeyEventToActiveTab");
+  if (use_native_events){
+    dict.SetString("command", "SendKeyEventToActiveBrowserWindow");

[kkania, 2011/03/10 00:28:58]

Modify the command name to say something about the fact that they are simulating
OS-level keyboard input.

[timothe faudot, 2011/03/10 05:34:32]

Changed to SendOSLevelKeyEvent

+  } else {
+    dict.SetString("command", "SendKeyEventToActiveTab");
+  }
   dict.SetInteger("type", key_event.type);
   dict.SetInteger("nativeKeyCode", key_event.key_code);
   dict.SetInteger("windowsKeyCode", key_event.key_code);
   dict.SetString("unmodifiedText", key_event.unmodified_text);
   dict.SetString("text", key_event.modified_text);
   dict.SetInteger("modifiers", key_event.modifiers);
   dict.SetBoolean("isSystemKey", false);
 
   *success = SendJSONRequest(tab_id, dict, &reply);
   if (!*success) {
@@ skipping 239 matching lines @@
     int tab_id, int* browser_index, int* tab_index) {
   if (!SendGetIndicesFromTabJSONRequest(automation(), tab_id,
                                         browser_index, tab_index)) {
     LOG(ERROR) << "Could not get browser and tab indices for WebDriver tab id";
     return false;
   }
   return true;
 }
 
 }  // namespace webdriver