Allow webdriver users to choose between sending the key events when...

chrome/test/webdriver/automation.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_WEBDRIVER_AUTOMATION_H_
 #define CHROME_TEST_WEBDRIVER_AUTOMATION_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 35 matching lines @@
   void Terminate();
 
   // Executes the given |script| in the specified frame of the current
   // tab. |result| will be set to the JSON result. Returns true on success.
   void ExecuteScript(int tab_id,
                      const std::string& frame_xpath,
                      const std::string& script,
                      std::string* result,
                      bool* success);
 
-  // Sends a key event to the current browser. Waits until the key has
+  // Sends a webkit key event to the current browser. Waits until the key has
   // been processed by the web page.
-  void SendWebKeyEvent(int tab_id, const WebKeyEvent& key_event, bool* success);
+  void SendWebKeyEvent(int tab_id,
+                       const WebKeyEvent& key_event,
+                       bool* success);
+
+  // Sends an OS level key event to the current browser. Waits until the key

[kkania, 2011/03/11 16:32:13]

Your func doesn't wait until the key has been processed by the page. Change the
func or fix the comment

+  // has been processed by the web page.
+  void SendNativeKeyEvent(int tab_id,
+                          ui::KeyboardCode keycode,

[kkania, 2011/03/11 16:32:13]

key_code

[timothe, 2011/03/21 18:02:05]

Done.

+                          int modifiers,
+                          bool* success);
 
   void NavigateToURL(int tab_id, const std::string& url, bool* success);
   void GoForward(int tab_id, bool* success);
   void GoBack(int tab_id, bool* success);
   void Reload(int tab_id, bool* success);
   void GetURL(int tab_id, std::string* url, bool* success);
   void GetGURL(int tab_id, GURL* gurl, bool* success);
   void GetTabTitle(int tab_id, std::string* tab_title, bool* success);
   void GetCookies(
       int tab_id, const GURL& gurl, std::string* cookies, bool* success);
@@ skipping 35 matching lines @@
   scoped_ptr<ProxyLauncher> launcher_;
 
   DISALLOW_COPY_AND_ASSIGN(Automation);
 };
 
 }  // namespace webdriver
 
 DISABLE_RUNNABLE_METHOD_REFCOUNT(webdriver::Automation);
 
 #endif  // CHROME_TEST_WEBDRIVER_AUTOMATION_H_