Allow webdriver users to choose between sending the key events when...

chrome/test/webdriver/chromedriver_tests.py

 #!/usr/bin/python
 
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Tests for ChromeDriver.
 
 If your test is testing a specific part of the WebDriver API, consider adding
 it to the appropriate place in the WebDriver tree instead.
@@ skipping 90 matching lines @@
       self.assertEquals('POST', expected.hdrs['Allow'])
 
   def testShouldGetA404WhenAttemptingToDeleteAnUnknownSession(self):
     request_url = self._launcher.GetURL() + '/session/unkown_session_id'
     try:
       SendRequest(request_url, method='DELETE')
       self.fail('Should have raised a urllib.HTTPError for returned 404')
     except urllib2.HTTPError, expected:
       self.assertEquals(404, expected.code)
 
+class BasicServerTest(unittest.TestCase):
   def testCanStartChromeDriverOnSpecificPort(self):
     launcher = ChromeDriverLauncher(port=9520)
     self.assertEquals(9520, launcher.GetPort())
     driver = WebDriver(launcher.GetURL(), 'chrome', 'any')
     driver.quit()
     launcher.Kill()
 
+  def testCanStartChromeWithNativeEventsEnabled(self):
+    launcher = ChromeDriverLauncher(use_native_events=True)
+    self.assertTrue(launcher.GetUseNativeEvents())
+    driver = WebDriver(launcher.GetURL(), 'chrome', 'any')

[Jason Leyba, 2011/03/04 19:25:12]

You're not verifying that the server has actually started with native events
enabled.

[timothe faudot, 2011/03/07 02:45:26]

This test only ensures that we can start the server with the flag
--native-events set and that it is stored in the session manager. For the test
that send key events it is in
webdriver_remote_tests.py/RemoteWebdriverNativeEventsTest

[Jason Leyba, 2011/03/07 03:32:56]

That's my point - you're only testing that you can start the server with the
--native-events flag and create a session.  There's nothing about this test that
verifies the server did anything with the --native-events flag.
I don't see any changes to webdriver_remote_tests in the latest patch.

+    driver.quit()
+    launcher.Kill()
+
 
 class CookieTest(unittest.TestCase):
   """Cookie test for the json webdriver protocol"""
 
   SEARCH = "http://www.google.com/webhp?hl=en"
 
   def setUp(self):
     self._launcher = ChromeDriverLauncher()
     self._driver = WebDriver(self._launcher.GetURL(), 'chrome', 'any')
 
@@ skipping 147 matching lines @@
     self.assertEquals('', url_parts[0])
     self.assertEquals('wd', url_parts[1])
     self.assertEquals('hub', url_parts[2])
     self.assertEquals('session', url_parts[3])
     self.assertEquals(data['sessionId'], url_parts[4])
 
 
 if __name__ == '__main__':
   unittest.main(module='chromedriver_tests',
                 testRunner=GTestTextTestRunner(verbosity=1))