Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 6628052: Supports SPD in VPD partition. (Closed)

Created:
9 years, 9 months ago by Louis
Modified:
9 years, 4 months ago
Reviewers:
dhendrix
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Supports SPD in VPD partition. VPD originally assumes the whole VPD partition only contains EPS and VPD 2.0 data. Since chrome-os-partner:2129 requests the to move SPD EEPROM content to VPD partition, VPD utility needs to be modified to support. This patch mainly re-factored the loadFile() and saveFile() functions to parse and store SPD data. In loadFile(), it tries to load SPD BBP first. Then VPD 2.0 BBP. In saveFile(), it writes in this order: EPS, SPD, VPD 2.0. This patch also refined some comments and removed few obscured/unused code. Change-Id: I3dc00f29e8120d30c8c48182e70f755018375637 BUG=chrome-os-partner:2129 TEST=I manually run the below commands on Z600 for cases: 1. a standalone VPD.bin file 2. Mario BIOS with VPD 1.0 partition 3. Mario BIOS with blank VPD partition 4. old version of VPD 2.0 partition (located at 0x100) 5. new BIOS with SPD data present (at 0x400) and VPD 2.0 (at 0x600) Command sequence is like: % vpd -f $F -s "some=string" % vpd -f $F -l # to verify % vpd -f $F -s "another=string" % vpd -f $F -l # confirm new string is added % vpd -f $F -O # make sure all VPD 2.0 data are clean Let me know if you are interested in detailed command log I've tested. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9812c3e

Patch Set 1 #

Patch Set 2 : refine the logic to next structure table. refine type 241 parameters. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -67 lines) Patch
M include/lib/lib_smbios.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M include/lib/vpd.h View 1 chunk +15 lines, -2 lines 0 comments Download
M include/lib/vpd_tables.h View 1 chunk +0 lines, -12 lines 0 comments Download
M lib/lib_smbios.c View 1 2 chunks +34 lines, -3 lines 0 comments Download
M vpd.c View 1 14 chunks +195 lines, -50 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Louis
9 years, 9 months ago (2011-03-07 15:59:26 UTC) #1
dhendrix
9 years, 9 months ago (2011-03-07 19:59:12 UTC) #2
LGTM

Thanks for doing this!

Powered by Google App Engine
This is Rietveld 408576698