Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 6628032: Shorten RemoveDirectory and rename to rmtree. Remove rmtree from fake_repos. (Closed)

Created:
9 years, 9 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Bernhard Bauer
Visibility:
Public.

Description

Shorten RemoveDirectory and rename to rmtree. Remove rmtree from fake_repos. Keep an alias to RemoveDirectory, will be removed in a later change. TEST=new unit test to test this function BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77463

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase against trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -114 lines) Patch
M gclient_utils.py View 1 2 chunks +31 lines, -39 lines 0 comments Download
M tests/fake_repos.py View 1 4 chunks +4 lines, -71 lines 0 comments Download
M tests/gclient_utils_test.py View 3 chunks +22 lines, -3 lines 0 comments Download
M tests/scm_unittest.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
Based on http://codereview.chromium.org/6625018 since it reuses the TrialDir class. This change deletes more code than ...
9 years, 9 months ago (2011-03-05 02:29:49 UTC) #1
M-A Ruel
ping
9 years, 9 months ago (2011-03-09 02:06:42 UTC) #2
Dirk Pranke
LGTM, although I'm not Evan ;)
9 years, 9 months ago (2011-03-09 02:26:19 UTC) #3
M-A Ruel
On 2011/03/09 02:26:19, dpranke wrote: > LGTM, although I'm not Evan ;) You'll do fine ...
9 years, 9 months ago (2011-03-09 14:44:23 UTC) #4
commit-bot: I haz the power
9 years, 9 months ago (2011-03-09 14:47:54 UTC) #5
Change committed as 77463

Powered by Google App Engine
This is Rietveld 408576698