Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: media/audio/audio_output_controller.cc

Issue 6628020: Cleaning up src/media to be consistent with static versus anonymous namespaces. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: fix namespaces Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_controller.cc
diff --git a/media/audio/audio_output_controller.cc b/media/audio/audio_output_controller.cc
index 5347c504b954186d64501e3f869b15a6e79b021a..10217f89ae929c05323b5947438a8aaf6ebfd26f 100644
--- a/media/audio/audio_output_controller.cc
+++ b/media/audio/audio_output_controller.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -6,22 +6,11 @@
#include "base/message_loop.h"
+namespace media {
+
// Signal a pause in low-latency mode.
static const int kPauseMark = -1;
-namespace {
-// Return true if the parameters for creating an audio stream is valid.
-// Return false otherwise.
-static bool CheckParameters(AudioParameters params) {
- if (!params.IsValid())
- return false;
Ami GONE FROM CHROMIUM 2011/03/04 22:52:04 Wow.
scherkus (not reviewing) 2011/03/07 14:57:56 I think when AudioParameters::IsValid() was create
- return true;
-}
-
-} // namespace
-
-namespace media {
-
AudioOutputController::AudioOutputController(EventHandler* handler,
uint32 capacity,
SyncReader* sync_reader)
@@ -45,7 +34,7 @@ scoped_refptr<AudioOutputController> AudioOutputController::Create(
AudioParameters params,
uint32 buffer_capacity) {
- if (!CheckParameters(params))
+ if (!params.IsValid())
return NULL;
if (!AudioManager::GetAudioManager())
@@ -72,7 +61,7 @@ scoped_refptr<AudioOutputController> AudioOutputController::CreateLowLatency(
DCHECK(sync_reader);
- if (!CheckParameters(params))
+ if (!params.IsValid())
return NULL;
if (!AudioManager::GetAudioManager())

Powered by Google App Engine
This is Rietveld 408576698