Cleaning up src/media to be consistent with static versus anonymous namespaces.

media/audio/audio_output_controller.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/audio_output_controller.h"
 
 #include "base/message_loop.h"
 
+namespace media {
+
 // Signal a pause in low-latency mode.
 static const int kPauseMark = -1;
 
-namespace {
-// Return true if the parameters for creating an audio stream is valid.
-// Return false otherwise.
-static bool CheckParameters(AudioParameters params) {
-  if (!params.IsValid())
-    return false;

[Ami GONE FROM CHROMIUM, 2011/03/04 22:52:04]

Wow.

[scherkus (not reviewing), 2011/03/07 14:57:56]

I think when AudioParameters::IsValid() was created from a refactoring I guess
no one caught this part

-  return true;
-}
-
-}  // namespace
-
-namespace media {
-
 AudioOutputController::AudioOutputController(EventHandler* handler,
                                              uint32 capacity,
                                              SyncReader* sync_reader)
     : handler_(handler),
       stream_(NULL),
       volume_(1.0),
       state_(kEmpty),
       buffer_(0, capacity),
       pending_request_(false),
       sync_reader_(sync_reader),
       message_loop_(NULL) {
 }
 
 AudioOutputController::~AudioOutputController() {
   DCHECK(kClosed == state_);
 }
 
 // static
 scoped_refptr<AudioOutputController> AudioOutputController::Create(
     EventHandler* event_handler,
     AudioParameters params,
     uint32 buffer_capacity) {
 
-  if (!CheckParameters(params))
+  if (!params.IsValid())
     return NULL;
 
   if (!AudioManager::GetAudioManager())
     return NULL;
 
   // Starts the audio controller thread.
   scoped_refptr<AudioOutputController> controller(new AudioOutputController(
       event_handler, buffer_capacity, NULL));
 
   controller->message_loop_ =
       AudioManager::GetAudioManager()->GetMessageLoop();
   controller->message_loop_->PostTask(
       FROM_HERE,
       NewRunnableMethod(controller.get(), &AudioOutputController::DoCreate,
                         params));
   return controller;
 }
 
 // static
 scoped_refptr<AudioOutputController> AudioOutputController::CreateLowLatency(
     EventHandler* event_handler,
     AudioParameters params,
     SyncReader* sync_reader) {
 
   DCHECK(sync_reader);
 
-  if (!CheckParameters(params))
+  if (!params.IsValid())
     return NULL;
 
   if (!AudioManager::GetAudioManager())
     return NULL;
 
   // Starts the audio controller thread.
   scoped_refptr<AudioOutputController> controller(new AudioOutputController(
       event_handler, 0, sync_reader));
 
   controller->message_loop_ =
@@ skipping 238 matching lines @@
   buffers_state.pending_bytes += buffer_.forward_bytes();
 
   // If we need more data then call the event handler to ask for more data.
   // It is okay that we don't lock in this block because the parameters are
   // correct and in the worst case we are just asking more data than needed.
   base::AutoUnlock auto_unlock(lock_);
   handler_->OnMoreData(this, buffers_state);
 }
 
 }  // namespace media