Cleaning up src/media to be consistent with static versus anonymous namespaces.

media/audio/audio_input_controller.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/audio_input_controller.h"
 
 #include "base/threading/thread_restrictions.h"
 #include "media/base/limits.h"
 
-namespace {
+namespace media {
 
-const int kMaxInputChannels = 2;
-
-}  // namespace
-
-namespace media {
+static const int kMaxInputChannels = 2;

[Ami GONE FROM CHROMIUM, 2011/03/04 22:52:04]

FWIW, for integral constants, using an unnamed enum is even sexier IMO, since it
requires no storage (which is more fun than out-of-line storage declarations for
static constants in classes, and by association even for bare constants):
enum { kMaxInputChannels = 2 };

Using an enum also prevents taking addresses/references of these literals, which
is almost always a good thing.

[scherkus (not reviewing), 2011/03/07 14:57:56]

Neat suggestion!  I'll keep that around for another clean-up task and get this
CL landed first.

 
 // static
 AudioInputController::Factory* AudioInputController::factory_ = NULL;
 
 AudioInputController::AudioInputController(EventHandler* handler)
     : handler_(handler),
       stream_(NULL),
       state_(kEmpty),
       thread_("AudioInputControllerThread") {
 }
@@ skipping 130 matching lines @@
 }
 
 void AudioInputController::OnError(AudioInputStream* stream, int code) {
   // Handle error on the audio controller thread.
   thread_.message_loop()->PostTask(
       FROM_HERE,
       NewRunnableMethod(this, &AudioInputController::DoReportError, code));
 }
 
 }  // namespace media