Reduce confusion by requiring "--config URL" args for debugging.

linux/recovery.sh

 #!/bin/sh
 #
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # This attempts to guide linux users through the process of putting a recovery
 # image onto a removeable USB drive.
 #
 # We may not need root privileges if we have the right permissions.
 #
 set -eu
 
 ##############################################################################
 # Configuration goes here
 
 # Where should we do our work? Use 'WORKDIR=' to make a temporary directory,
 # but using a persistent location may let us resume interrupted downloads or
 # run again without needing to download a second time.
 WORKDIR=${WORKDIR:-/tmp/tmp.crosrec}
 
-# Where do we look for the config file? Note that we can override this by just
-# specifying the config file URL on the command line.
-CONFIGURL="${1:-https://dl.google.com/dl/edgedl/chromeos/recovery/recovery.conf}"
+# Where do we look for the config file? We can override this for debugging by
+# specifying "--config URL" on the command line, but curl and wget may handle
+# file URLs differently.
+CONFIGURL="${2:-https://dl.google.com/dl/edgedl/chromeos/recovery/recovery.conf}"
 
 # Device to put this stuff on, perhaps the user knows best?
 DEVICE="${DEVICE:-}"
 
 # What version is this script? It must match the 'recovery_tool_version=' value
 # in the config file that we'll download.
 MYVERSION='0.9.2'
 
 
 ##############################################################################
@@ skipping 745 matching lines @@
   if [ -n "$DISKUTIL" ]; then
     diskutil unmountDisk "$1" || ufatal "Unable to unmount $1."
   else
     umount "$1" || ufatal "Unable to unmount $1."
   fi
 }
 
 ##############################################################################
 # Okay, do something...
 
+# Warn about usage
+if [ -n "${1:-}" ] && [ "$1" != "--config" ]; then
+  echo "This program takes no arguments. Just run it."
+  # That's not really true. For debugging you can specify "--config URL".
+  exit 1
+fi
+
 # Make sure we have the tools we need
 require_utils
 
 # Need a place to work. We prefer a fixed location so we can try to resume any
 # interrupted downloads.
 if [ -n "$WORKDIR" ]; then
   if [ ! -d "$WORKDIR" ] && ! mkdir "$WORKDIR" ; then
     warn "Using temporary directory"
     WORKDIR=
   fi
@@ skipping 121 matching lines @@
 prompt "Shall I remove the temporary files now? [y/n] "
 read tmp
 case $tmp in
   [Yy]*)
     cd
     \rm -rf ${WORKDIR}
     ;;
 esac
 
 exit 0