Add a wrapper function of LoadKernel()

lib/chromeos/load_util.c

+/*
+ * Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ *
+ * Alternatively, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") version 2 as published by the Free
+ * Software Foundation.
+ */
+
+#include <common.h>
+#include <chromeos/load_util.h>
+
+#define PREFIX "load_kernel: "
+
+int load_kernel(LoadKernelParams *params, uint8_t *kernel_sign_key_blob,

[sjg, 2011/03/06 21:34:09]

It's not great having load_kernel() and LoadKernel(). Can you think of another
name? Is this basically just packing params into the struct?

[Che-Liang Chiou, 2011/03/07 05:06:52]

I think you are right. I was thinking that this function can be reused by
rewritable firmware and recovery firmware. But maybe we should wait until the
calling pattern to LoadKernel() is clearer. After that we factor out common part
and share codes.

+                void *kernel_buffer, uint64_t kernel_buffer_size,

[sjg, 2011/03/06 21:34:09]

Why void* rather than char*? If an address perhaps just an u_int32_t address
would do?

[Che-Liang Chiou, 2011/03/07 05:06:52]

I am not sure if I am making the right choice here: I use void* because
vboot_reference uses void* for kernel_buffer field of LoadKernelParams.

If you think we should use char* regardless of what type vboot_reference, I am
okay with that.

+                uint64_t boot_flags)
+{
+        block_dev_desc_t *dev_desc;
+
+        dev_desc = get_bootdev();
+        if (!dev_desc) {
+                debug(PREFIX "get_bootdev fail\n");
+                return LOAD_KERNEL_NOT_FOUND;
+        }
+
+        params->header_sign_key_blob = kernel_sign_key_blob;
+
+        params->bytes_per_lba = (uint64_t) dev_desc->blksz;
+        params->ending_lba = (uint64_t) get_limit() - 1;
+
+        params->kernel_buffer = kernel_buffer;
+        params->kernel_buffer_size = kernel_buffer_size;
+
+        params->boot_flags = boot_flags;
+
+        return LoadKernel(params);
+}