Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6627081: IndexedDB: Add --level-db flag, and pipe through to WebIDBFactory::open. (Closed)

Created:
9 years, 9 months ago by hans
Modified:
9 years, 5 months ago
Reviewers:
dgrogan, jorlow, andreip3000
CC:
chromium-reviews, jam, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

IndexedDB: Add --indexeddb-use-leveldb flag, and pipe through to WebIDBFactory::open. BUG=64078 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77802

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M chrome/renderer/renderer_webidbfactory_impl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/renderer_webidbfactory_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 1 chunk +11 lines, -1 line 0 comments Download
M content/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/common/content_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hans
This depends on https://bugs.webkit.org/show_bug.cgi?id=55948 Please review.
9 years, 9 months ago (2011-03-08 18:28:51 UTC) #1
jorlow
http://codereview.chromium.org/6627081/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/6627081/diff/1/chrome/common/chrome_switches.cc#newcode268 chrome/common/chrome_switches.cc:268: const char kLevelDBIndexedDatabase[] = "level-db"; Let's make this a ...
9 years, 9 months ago (2011-03-08 18:45:54 UTC) #2
hans
Thanks for the review. Will run try jobs when webkit rolls. http://codereview.chromium.org/6627081/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): ...
9 years, 9 months ago (2011-03-09 12:22:09 UTC) #3
hans
On 2011/03/09 12:22:09, hans wrote: > Thanks for the review. Will run try jobs when ...
9 years, 9 months ago (2011-03-10 11:41:47 UTC) #4
andreip3000
9 years, 9 months ago (2011-03-10 11:47:02 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698