ImportantFileWriter: check return value of PostTask...

chrome/common/important_file_writer.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/important_file_writer.h"
 
 #include <stdio.h>
 
 #include <string>
 
@@ skipping 88 matching lines @@
   DCHECK(CalledOnValidThread());
   return timer_.IsRunning();
 }
 
 void ImportantFileWriter::WriteNow(const std::string& data) {
   DCHECK(CalledOnValidThread());
 
   if (HasPendingWrite())
     timer_.Stop();
 
-  // TODO(sanjeevr): Add a DCHECK for the return value of PostTask.
-  // (Some tests fail if we add the DCHECK and they need to be fixed first).
-  file_message_loop_proxy_->PostTask(FROM_HERE,
-                                     new WriteToDiskTask(path_, data));
+  if (!file_message_loop_proxy_->PostTask(FROM_HERE,
+                                          new WriteToDiskTask(path_, data))) {
+    // Posting the task to background message loop is not expected
+    // to fail, but if it does, avoid loosing data and just hit the disk

[sanjeevr, 2011/03/08 19:42:05]

Spelling Nit: loosing => losing

[Paweł Hajdan Jr., 2011/03/09 09:09:22]

Done.

+    // on the current thread.
+    // TODO(phajdan.jr): Fix test failures on Win and enable code below.
+#if !defined(OS_WIN)
+    NOTREACHED();
+
+    WriteToDiskTask write_task(path_, data);
+    write_task.Run();
+#endif
+  }
 }
 
 void ImportantFileWriter::ScheduleWrite(DataSerializer* serializer) {
   DCHECK(CalledOnValidThread());
 
   DCHECK(serializer);
   serializer_ = serializer;
 
   if (!MessageLoop::current()) {
     // Happens in unit tests.
@@ skipping 11 matching lines @@
   DCHECK(serializer_);
   std::string data;
   if (serializer_->SerializeData(&data)) {
     WriteNow(data);
   } else {
     LOG(WARNING) << "failed to serialize data to be saved in "
                  << path_.value();
   }
   serializer_ = NULL;
 }