ImportantFileWriter: check return value of PostTask...

chrome/browser/extensions/extension_menu_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/json/json_reader.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
 #include "base/scoped_vector.h"
@@ skipping 13 matching lines @@
 #include "webkit/glue/context_menu.h"
 
 using testing::_;
 using testing::AtLeast;
 using testing::Return;
 using testing::SaveArg;
 
 // Base class for tests.
 class ExtensionMenuManagerTest : public testing::Test {
  public:
-  ExtensionMenuManagerTest() : next_id_(1) {}
-  ~ExtensionMenuManagerTest() {}
+  ExtensionMenuManagerTest()
+      : ui_thread_(BrowserThread::UI, &message_loop_),
+        file_thread_(BrowserThread::FILE, &message_loop_),

[asargent_no_longer_on_chrome, 2011/03/09 20:53:17]

same message loop to 2 threads?

[Paweł Hajdan Jr., 2011/03/10 07:30:35]

In this case I'm absolutely sure this is valid. Here's how it works:

There are no two threads here, only one. There are two "labels" though, UI and
FILE. In the browser those are all real threads of course, each with its own
message loop. For tests however, it is often simpler to have just one message
loop (it also makes the test more deterministic).

BrowserThread maps thread labels (UI, FILE, IO and so on) to MessageLoops. It
can be seen as sort of a switchboard. Now when I'm using same message loop for 2
thread labels I'm saying I just don't want to create more threads, and I want
everything to run on the same thread.

Short story: it would be incorrect in the browser code, but in test code it is
perfectly fine, and makes things simpler. There are many other existing tests
doing so already.

+        next_id_(1) {
+  }
 
   // Returns a test item.
   ExtensionMenuItem* CreateTestItem(Extension* extension) {
     ExtensionMenuItem::Type type = ExtensionMenuItem::NORMAL;
     ExtensionMenuItem::ContextList contexts(ExtensionMenuItem::ALL);
     ExtensionMenuItem::Id id(NULL, extension->id(), next_id_++);
     return new ExtensionMenuItem(id, "test", false, type, contexts);
   }
 
   // Creates and returns a test Extension. The caller does *not* own the return
   // value.
   Extension* AddExtension(std::string name) {
     scoped_refptr<Extension> extension = prefs_.AddExtension(name);
     extensions_.push_back(extension);
     return extension;
   }
 
  protected:
+  MessageLoopForUI message_loop_;
+  BrowserThread ui_thread_;
+  BrowserThread file_thread_;
+
   ExtensionMenuManager manager_;
   ExtensionList extensions_;
   TestExtensionPrefs prefs_;
   int next_id_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ExtensionMenuManagerTest);
 };
 
 // Tests adding, getting, and removing items.
@@ skipping 338 matching lines @@
 
   ASSERT_FALSE(manager_.context_items_.empty());
 
   manager_.RemoveContextMenuItem(item1->id());
   manager_.RemoveContextMenuItem(item2->id());
 
   ASSERT_TRUE(manager_.context_items_.empty());
 }
 
 TEST_F(ExtensionMenuManagerTest, ExecuteCommand) {
-  MessageLoopForUI message_loop;
-  BrowserThread ui_thread(BrowserThread::UI, &message_loop);
-
   MockTestingProfile profile;
 
   scoped_ptr<MockExtensionEventRouter> mock_event_router(
       new MockExtensionEventRouter(&profile));
 
   ContextMenuParams params;
   params.media_type = WebKit::WebContextMenuData::MediaTypeImage;
   params.src_url = GURL("http://foo.bar/image.png");
   params.page_url = GURL("http://foo.bar");
   params.selection_text = ASCIIToUTF16("Hello World");
@@ skipping 49 matching lines @@
   ASSERT_EQ(params.page_url.spec(), tmp);
 
   string16 tmp16;
   ASSERT_TRUE(info->GetString("selectionText", &tmp16));
   ASSERT_EQ(params.selection_text, tmp16);
 
   bool bool_tmp = true;
   ASSERT_TRUE(info->GetBoolean("editable", &bool_tmp));
   ASSERT_EQ(params.is_editable, bool_tmp);
 }