Chromium Code Reviews| Index: tests/filesystem_mock.py |
| diff --git a/tests/filesystem_mock.py b/tests/filesystem_mock.py |
| index 6ce656110942e3027b7237021532a9108f73c348..f8a3a1d87ddc7b65756ddababcef17c0409e009c 100644 |
| --- a/tests/filesystem_mock.py |
| +++ b/tests/filesystem_mock.py |
| @@ -32,10 +32,15 @@ class MockFileSystem(object): |
| def _split(self, path): |
| return path.rsplit(self.sep, 1) |
| + def abspath(self, path): |
| + if path.endswith(self.sep): |
| + return path[:-1] |
| + return path |
| + |
| def dirname(self, path): |
| - if not self.sep in path: |
| + if self.sep not in path: |
|
M-A Ruel
2011/03/08 20:24:03
I always forgot the subtle difference there. (?)
Dirk Pranke
2011/03/08 22:05:27
I think it's mostly a question of operator precede
|
| return '' |
| - return self._split(path)[0] |
| + return self._split(path)[0] or self.sep |
| def exists(self, path): |
| return self.isfile(path) or self.isdir(path) |
| @@ -56,7 +61,7 @@ class MockFileSystem(object): |
| return any(f.startswith(path) for f in files) |
| def join(self, *comps): |
| - # FIXME: might want tests for this and/or a better comment about how |
| + # TODO: Might want tests for this and/or a better comment about how |
| # it works. |
| return re.sub(re.escape(os.path.sep), self.sep, os.path.join(*comps)) |