Issue 6627048: X64 Crankshaft: Revert r7071 and fix DoStoreContextSlot in a different way.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6627048: X64 Crankshaft: Revert r7071 and fix DoStoreContextSlot in a different way. (Closed)

Created:
9 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund, Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 Crankshaft: Revert r7071 and fix DoStoreContextSlot in a different way. Committed: http://code.google.com/p/v8/source/detail?r=7073

Patch Set 1 #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -11 lines)			Patch
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/lithium-x64.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+4 lines, -1 line	2 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/6627048/diff/1/src/x64/lithium-x64.cc File src/x64/lithium-x64.cc (right): http://codereview.chromium.org/6627048/diff/1/src/x64/lithium-x64.cc#newcode1735 src/x64/lithium-x64.cc:1735: temp = TempRegister(); Do we gain anything from ...

9 years, 9 months ago (2011-03-07 11:19:21 UTC) #2

William Hesse

9 years, 9 months ago (2011-03-07 11:44:31 UTC) #3

http://codereview.chromium.org/6627048/diff/1/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):

http://codereview.chromium.org/6627048/diff/1/src/x64/lithium-x64.cc#newcode1735
src/x64/lithium-x64.cc:1735: temp = TempRegister();
On 2011/03/07 11:19:21, Rico wrote:
> Do we gain anything from not just initializing temp to TempRegister in all
> cases?
We do not allocate a temp register, and thus do not possible spill a register.

Expand Messages | Collapse Messages