chrome/browser/ui/gtk/js_modal_dialog_gtk.h - Issue 6627038: gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/js_modal_dialog_gtk.h

Issue 6627038: gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc ('K') | « chrome/browser/ui/gtk/instant_confirm_dialog_gtk.cc ('k') | chrome/browser/ui/gtk/js_modal_dialog_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/js_modal_dialog_gtk.h

diff --git a/chrome/browser/ui/gtk/js_modal_dialog_gtk.h b/chrome/browser/ui/gtk/js_modal_dialog_gtk.h

index 5626651501b0a533b6f2d50d177f98d6d721f618..082731ebfb31ab8577c8f46e6d355f95ba092d6a 100644

--- a/chrome/browser/ui/gtk/js_modal_dialog_gtk.h

+++ b/chrome/browser/ui/gtk/js_modal_dialog_gtk.h

@@ -22,7 +22,7 @@ class JSModalDialogGtk : public NativeAppModalDialog {

gfx::NativeWindow parent_window);

virtual ~JSModalDialogGtk();

- // Overridden from NativeAppModalDialog:

+ // NativeAppModalDialog:

virtual int GetAppModalDialogButtons() const;

virtual void ShowAppModalDialog();

virtual void ActivateAppModalDialog();

@@ -31,7 +31,7 @@ class JSModalDialogGtk : public NativeAppModalDialog {

virtual void CancelAppModalDialog();

private:

- CHROMEGTK_CALLBACK_1(JSModalDialogGtk, void, OnDialogResponse, int);

+ CHROMEGTK_CALLBACK_1(JSModalDialogGtk, void, OnResponse, int);

scoped_ptr<JavaScriptAppModalDialog> dialog_;

GtkWidget* gtk_dialog_;