chrome/browser/ui/gtk/instant_confirm_dialog_gtk.cc - Issue 6627038: gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/instant_confirm_dialog_gtk.cc

Issue 6627038: gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc ('K') | « chrome/browser/ui/gtk/instant_confirm_dialog_gtk.h ('k') | chrome/browser/ui/gtk/js_modal_dialog_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/instant_confirm_dialog_gtk.cc

diff --git a/chrome/browser/ui/gtk/instant_confirm_dialog_gtk.cc b/chrome/browser/ui/gtk/instant_confirm_dialog_gtk.cc

index 446428c8236711024ae236307f7764e88d39b600..31abb00f78c774f0abc926f7b7278b41ba2c1c70 100644

--- a/chrome/browser/ui/gtk/instant_confirm_dialog_gtk.cc

+++ b/chrome/browser/ui/gtk/instant_confirm_dialog_gtk.cc

@@ -34,8 +34,7 @@ InstantConfirmDialogGtk::InstantConfirmDialogGtk(

GTK_STOCK_CANCEL, GTK_RESPONSE_REJECT,

GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,

NULL);

- g_signal_connect(dialog_, "response",

- G_CALLBACK(OnDialogResponseThunk), this);

+ g_signal_connect(dialog_, "response", G_CALLBACK(OnResponseThunk), this);

GtkBox* vbox = GTK_BOX(GTK_DIALOG(dialog_)->vbox);

gtk_box_set_spacing(vbox, gtk_util::kControlSpacing);

@@ -64,9 +63,8 @@ InstantConfirmDialogGtk::~InstantConfirmDialogGtk() {

gtk_widget_destroy(dialog_);

}

-void InstantConfirmDialogGtk::OnDialogResponse(GtkWidget* dialog,

- int response) {

- if (response == GTK_RESPONSE_ACCEPT)

+void InstantConfirmDialogGtk::OnResponse(GtkWidget* dialog, int response_id) {

+ if (response_id == GTK_RESPONSE_ACCEPT)

InstantController::Enable(profile_);

delete this;