Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/browser/ui/gtk/importer/import_dialog_gtk.cc

Issue 6627038: gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/importer/import_dialog_gtk.cc
diff --git a/chrome/browser/ui/gtk/importer/import_dialog_gtk.cc b/chrome/browser/ui/gtk/importer/import_dialog_gtk.cc
index 6fa31084efd738cfadf7b4a3b61a1a27e071fd0c..52feb82aa85338ec94a57699a9d9dbf0d71dab50 100644
--- a/chrome/browser/ui/gtk/importer/import_dialog_gtk.cc
+++ b/chrome/browser/ui/gtk/importer/import_dialog_gtk.cc
@@ -122,14 +122,13 @@ ImportDialogGtk::ImportDialogGtk(GtkWindow* parent, Profile* profile,
// Disable controls until source profiles are loaded.
SetDialogControlsSensitive(false);
- g_signal_connect(dialog_, "response",
- G_CALLBACK(OnDialogResponseThunk), this);
+ g_signal_connect(dialog_, "response", G_CALLBACK(OnResponseThunk), this);
UpdateDialogButtons();
gtk_util::ShowDialogWithLocalizedSize(dialog_,
IDS_IMPORT_DIALOG_WIDTH_CHARS,
- -1, // height
+ -1, // height
false); // resizable
}
@@ -138,9 +137,9 @@ ImportDialogGtk::~ImportDialogGtk() {
importer_list_->SetObserver(NULL);
}
-void ImportDialogGtk::OnDialogResponse(GtkWidget* widget, int response) {
+void ImportDialogGtk::OnResponse(GtkWidget* dialog, int response_id) {
gtk_widget_hide_all(dialog_);
- if (response == GTK_RESPONSE_ACCEPT) {
+ if (response_id == GTK_RESPONSE_ACCEPT) {
uint16 items = GetCheckedItems();
if (items == 0) {
ImportCompleted();

Powered by Google App Engine
This is Rietveld 408576698