chrome/browser/ui/gtk/download_in_progress_dialog_gtk.cc - Issue 6627038: gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/download_in_progress_dialog_gtk.cc

Issue 6627038: gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/gtk/dialogs_gtk.cc ('k') | chrome/browser/ui/gtk/edit_search_engine_dialog.h » ('j') | chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/download_in_progress_dialog_gtk.cc

diff --git a/chrome/browser/ui/gtk/download_in_progress_dialog_gtk.cc b/chrome/browser/ui/gtk/download_in_progress_dialog_gtk.cc

index de3cb3184ccd4fa0ca261900d4a62345e58691f9..936346700e7b8e3a16b215d33bcaed34d862231d 100644

--- a/chrome/browser/ui/gtk/download_in_progress_dialog_gtk.cc

+++ b/chrome/browser/ui/gtk/download_in_progress_dialog_gtk.cc

@@ -76,9 +76,9 @@ DownloadInProgressDialogGtk::DownloadInProgressDialogGtk(Browser* browser)

gtk_widget_show_all(dialog);

}

-void DownloadInProgressDialogGtk::OnResponse(GtkWidget* widget,

- int response) {

- gtk_widget_destroy(widget);

- browser_->InProgressDownloadResponse(response == GTK_RESPONSE_ACCEPT);

+void DownloadInProgressDialogGtk::OnResponse(GtkWidget* dialog,

+ int response_id) {

+ gtk_widget_destroy(dialog);

+ browser_->InProgressDownloadResponse(response_id == GTK_RESPONSE_ACCEPT);

delete this;

}