Issue 6627001: Build WebKit Full Screen API. Support is disabled by default; enable with --enable-fullscreen.

Issue 6627001: Build WebKit Full Screen API. Support is disabled by default; enable with --enable-fullscreen. (Closed)

Created:
9 years, 9 months ago by ddorwin

Modified:
9 years, 7 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, sjl

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Build WebKit Full Screen API. Support is disabled by default; enable with --enable-fullscreen. Commit after WK bug 44797 (r79774). Fullscreen tests are temporarily until expectations can be updated. (Deleted test video-play-suspend.html is removed from test_expectations to fix lint errors.) BUG=16735 TEST=fullscreen layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76979

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -5 lines)			Patch
M	build/features_override.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages.cc	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/glue/webpreferences.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

I think you have some code merge leftovers ;) LGTM assuming you clean those up ...

9 years, 9 months ago (2011-03-04 02:11:47 UTC) #2

scherkus (not reviewing)

9 years, 9 months ago (2011-03-04 02:12:20 UTC) #3

On 2011/03/04 02:11:47, scherkus wrote:
> I think you have some code merge leftovers ;)
> 
> LGTM assuming you clean those up
> 
> http://codereview.chromium.org/6627001/diff/1/chrome/common/chrome_switches.h
> File chrome/common/chrome_switches.h (right):
> 
>
http://codereview.chromium.org/6627001/diff/1/chrome/common/chrome_switches.h...
> chrome/common/chrome_switches.h:151: extern const char kEnableGPUPlugin[];
> did you mean to add in kEnableGPUPlugin?  I don't see it declared in
> chrome_switches.cc
> 
>
http://codereview.chromium.org/6627001/diff/1/webkit/tools/layout_tests/test_...
> File webkit/tools/layout_tests/test_expectations.txt (left):
> 
>
http://codereview.chromium.org/6627001/diff/1/webkit/tools/layout_tests/test_...
> webkit/tools/layout_tests/test_expectations.txt:14: BUGCR74092 :
> http/tests/media/video-play-suspend.html = TIMEOUT
> did you mean to remove this?

Just read your comment about video-play-suspend.html!!

I think kEnableGPUPlugin comment still stands, though.

Expand Messages | Collapse Messages