Issue 6626072: Add the possibility for a code stub to be non-movable...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6626072: Add the possibility for a code stub to be non-movable... (Closed)

Created:
9 years, 9 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add the possibility for a code stub to be non-movable Non-moveable code-stube are allocated in large object space. They are only required on ARM where the different C-entry stubs are required to never move. This gets rid of pre-computing these stubs and hope that they never move. Also for crankshaft the C-entry stub which saved doubles is not generated in the snapshot so it ends up being generated at runtime and potentially move. Committed: http://code.google.com/p/v8/source/detail?r=7097

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -61 lines)			Patch
M	src/arm/code-stubs-arm.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/code-stubs.h	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	src/code-stubs.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/factory.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/factory.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/heap.h	View	1	4 chunks	+4 lines, -20 lines	0 comments	Download
M	src/heap.cc	View	1	5 chunks	+10 lines, -36 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM I would prefer 'immovable' to 'fixed' since fixed is the opposite of 'broken'.

9 years, 9 months ago (2011-03-09 10:11:52 UTC) #2

Søren Thygesen Gjesse

9 years, 9 months ago (2011-03-09 11:50:49 UTC) #3

On 2011/03/09 10:11:52, Erik Corry wrote:
> LGTM
> 
> I would prefer 'immovable' to 'fixed' since fixed is the opposite of 'broken'.

Changed 'fixed' to 'immovable'.

Expand Messages | Collapse Messages