Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 6626054: Switch to wstrings. (Closed)

Created:
9 years, 9 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
brettw, Evan Martin
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

wstring removal fix. BUG=23581 TEST=No visible change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77205

Patch Set 1 #

Patch Set 2 : Fix to just string16-ify. #

Patch Set 3 : Drop empty file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M chrome/browser/history/history_publisher.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/history_publisher.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
To you; you wrote it > 2 yrs ago.
9 years, 9 months ago (2011-03-07 21:13:17 UTC) #1
Avi (use Gerrit)
OK, so Brett is sick today. FYI to him, to Evan for review, then.
9 years, 9 months ago (2011-03-07 21:35:14 UTC) #2
brettw
On Mon, Mar 7, 2011 at 1:35 PM, <avi@chromium.org> wrote: > OK, so Brett is ...
9 years, 9 months ago (2011-03-07 21:41:13 UTC) #3
Evan Martin
Yeah, the .c_str looks fine to me (albeit a bit scary). PageData is private so ...
9 years, 9 months ago (2011-03-07 21:48:25 UTC) #4
Avi (use Gerrit)
On 2011/03/07 21:41:13, brettw wrote: > What is the reason for this change? As far ...
9 years, 9 months ago (2011-03-07 21:49:10 UTC) #5
Evan Martin
char16 sgtm
9 years, 9 months ago (2011-03-07 21:50:13 UTC) #6
Avi (use Gerrit)
OK, here ya go. (Trybots still pending; will commit when clear.)
9 years, 9 months ago (2011-03-07 22:24:15 UTC) #7
Evan Martin
side note: why does this header have no comments as to what it does? ಠ_ಠ
9 years, 9 months ago (2011-03-07 22:27:18 UTC) #8
Evan Martin
9 years, 9 months ago (2011-03-07 22:27:30 UTC) #9
LGTM otherwise

Powered by Google App Engine
This is Rietveld 408576698