Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 6626045: Pass VbSharedData between LoadFirmware() and LoadKernel() (Closed)

Created:
9 years, 9 months ago by Randall Spangler
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

This is necessary to pass additional information about whether firmware A or B is being run. This change also passes the GBB directly into LoadFirmware() and LoadKernel(). Change-Id: I976c11c82c3d665a4feb88226e919f16c2440f60 BUG=chrome-os-partner:1657 TEST=manual - see below make && make runtests Then test verifying a test image in both dev mode (-b1, no key specified) and recovery mode (key specified) build/utility/load_kernel_test -b1 ~/b/USB_images/0.11.224.0-alex/chromiumos_test_image.bin build/utility/load_kernel_test ~/b/USB_images/0.11.224.0-alex/chromiumos_test_image.bin tests/devkeys/recovery_key.vbpubk And make sure the firmware with this change actually boots to USB and SSD. NOTE: u-boot-next needs to change to work with this change. will attempt a follow-up CL with that change Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=95c4031

Patch Set 1 #

Patch Set 2 : Fixed load_kernel_test #

Total comments: 6

Patch Set 3 : Fixes from code review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -71 lines) Patch
M firmware/include/load_firmware_fw.h View 1 2 3 chunks +15 lines, -15 lines 0 comments Download
M firmware/include/load_kernel_fw.h View 2 chunks +10 lines, -2 lines 0 comments Download
M firmware/include/vboot_nvstorage.h View 2 chunks +4 lines, -0 lines 0 comments Download
M firmware/include/vboot_struct.h View 1 2 2 chunks +44 lines, -1 line 0 comments Download
M firmware/lib/include/vboot_common.h View 1 3 chunks +16 lines, -1 line 0 comments Download
M firmware/lib/vboot_common.c View 1 2 3 chunks +66 lines, -1 line 0 comments Download
M firmware/lib/vboot_firmware.c View 6 chunks +20 lines, -19 lines 0 comments Download
M firmware/lib/vboot_kernel.c View 1 6 chunks +25 lines, -3 lines 0 comments Download
M firmware/linktest/main.c View 1 chunk +3 lines, -0 lines 0 comments Download
M firmware/stub/load_firmware_stub.c View 3 chunks +9 lines, -7 lines 0 comments Download
M utility/load_firmware_test.c View 1 2 4 chunks +16 lines, -18 lines 0 comments Download
M utility/load_kernel_test.c View 1 3 chunks +50 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Randall Spangler
PTAL. Working on getting u-boot-next to compile now.
9 years, 9 months ago (2011-03-08 18:03:41 UTC) #1
Bill Richardson
I think I grok the code enough to say LGTM. A few requests for clarification ...
9 years, 9 months ago (2011-03-09 20:52:20 UTC) #2
Randall Spangler
http://codereview.chromium.org/6626045/diff/2001/firmware/include/load_kernel_fw.h File firmware/include/load_kernel_fw.h (right): http://codereview.chromium.org/6626045/diff/2001/firmware/include/load_kernel_fw.h#newcode42 firmware/include/load_kernel_fw.h:42: * On output, this will contain the actual On ...
9 years, 9 months ago (2011-03-09 21:11:35 UTC) #3
Bill Richardson
9 years, 9 months ago (2011-03-09 22:14:44 UTC) #4
Much clearer. Thanks!

LGTM.

Powered by Google App Engine
This is Rietveld 408576698