Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: lib/cros_build_lib.py

Issue 6626039: Revert "Plumb in crprocess instead of RunCommand to allow quiet operation." (Closed) Base URL: http://git.chromium.org/git/chromite.git@master
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/cros_subprocess.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/cros_build_lib.py
diff --git a/lib/cros_build_lib.py b/lib/cros_build_lib.py
index 2ea48bf58d617a30a27fb53287df8ede219bf5b6..fe30fcbcf705c11fb6767b55fc934053887538c7 100644
--- a/lib/cros_build_lib.py
+++ b/lib/cros_build_lib.py
@@ -117,7 +117,6 @@ def RunCommand(cmd, print_cmd=True, error_ok=False, error_message=None,
return cmd_result
-#TODO(sjg): Remove this in favor of operation.Die
def Die(message):
"""Emits a red error message and halts execution.
@@ -129,7 +128,6 @@ def Die(message):
sys.exit(1)
-#TODO(sjg): Remove this in favor of operation.Warning
# pylint: disable-msg=W0622
def Warning(message):
"""Emits a yellow warning message and continues execution.
@@ -141,18 +139,14 @@ def Warning(message):
Color(_STDOUT_IS_TTY).Color(Color.YELLOW, '\nWARNING: ' + message))
-# This command is deprecated in favor of operation.Info()
-# It is left here for the moment so people are aware what happened.
-# The reason is that this is not aware of the terminal output restrictions such
-# as verbose, quiet and subprocess output. You should not be calling this.
-# def Info(message):
-# """Emits a blue informational message and continues execution.
-#
-# Args:
-# message: The message to be emitted.
-# """
-# print >> sys.stderr, (
-# Color(_STDOUT_IS_TTY).Color(Color.BLUE, '\nINFO: ' + message))
+def Info(message):
+ """Emits a blue informational message and continues execution.
+
+ Args:
+ message: The message to be emitted.
+ """
+ print >> sys.stderr, (
+ Color(_STDOUT_IS_TTY).Color(Color.BLUE, '\nINFO: ' + message))
def ListFiles(base_dir):
« no previous file with comments | « no previous file | lib/cros_subprocess.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698