Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 6626035: Enable ChromeFrame net tests. These tests regressed with the change in the ch... (Closed)

Created:
9 years, 9 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, amit
Visibility:
Public.

Description

Enable ChromeFrame net tests. These tests regressed with the change in the chunked upload code in net to move the formatting of individual chunks to the http network stack. This caused the URLRequestTestHTTP.TestPostChunkedDataBeforeStart test to hang in ChromeFrame. Fix is to ensure that the individual chunks are properly formatted while marshaling them over IPC. BUG=none TEST=chrome frame net tests should pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77002

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/common/common_param_traits.cc View 1 1 chunk +13 lines, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 9 months ago (2011-03-04 23:40:12 UTC) #1
amit
9 years, 9 months ago (2011-03-04 23:45:18 UTC) #2
lg

Powered by Google App Engine
This is Rietveld 408576698