Issue 6626034: Just regular mount

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6626034: Just regular mount (Closed)

Created:
9 years, 9 months ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
dhendrix, stefanreinauer, jglasgow

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/initramfs.git@master

Visibility:
Public.

Description

Just regular mount * Something in log saving, or buildbot, or image_to_usb damages the filesystem on /dev/sdb1. So opening it readonly may fail. BUG=chrome-os-partner:2422 TEST=run through install shim, success. Change-Id: I0d90d0f17ba109c53dde4a328ac0acaa04896055 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4fc3f46

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	init	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dhendrix

On 2011/03/05 04:46:21, Nick Sanders wrote: LGTM, but please get around to testing before making ...

9 years, 9 months ago (2011-03-05 04:56:03 UTC) #2

jglasgow

9 years, 9 months ago (2011-03-07 17:02:59 UTC) #4

I know this is closed, but I just took a look and the comment is no longer
correct.

http://codereview.chromium.org/6626034/diff/1/init
File init (right):

http://codereview.chromium.org/6626034/diff/1/init#newcode310
init:310: # Mounting ext3 as ext2 since the journal is unneeded in ro.
This comment is no longer relevant

Expand Messages | Collapse Messages