Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 6626028: Modify stateful update clobber logic to write to different file. (Closed)

Created:
9 years, 9 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, ericli, DaleCurtis
Visibility:
Public.

Description

Modify stateful update clobber logic to write to different file. We no longer want to use clobber-state because /usr/local and /var may have too much data to fit into /tmp. This change has .stateful_update maintain all state rather than the factory file. Change-Id: Ia4fad0395adc5709b84d96a1aef35b88e729fac6 BUG=chromium-os:12209 TEST=Ran in a vm w/ and w/out setting stateful_update file to clean Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8086c3f

Patch Set 1 #

Total comments: 3

Patch Set 2 : nits #

Patch Set 3 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M stateful_update View 1 2 2 chunks +19 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sosa
9 years, 9 months ago (2011-03-04 23:20:01 UTC) #1
petkov
9 years, 9 months ago (2011-03-04 23:31:57 UTC) #2
a couple of nits, LGTM otherwise.

http://codereview.chromium.org/6626028/diff/1/stateful_update
File stateful_update (right):

http://codereview.chromium.org/6626028/diff/1/stateful_update#newcode36
stateful_update:36: DEVSERVER_URL=$(grep CHROMEOS_DEVSERVER
${STATEFUL_DIR}${LSB_RELEASE} | \
no need for trailing \

http://codereview.chromium.org/6626028/diff/1/stateful_update#newcode59
stateful_update:59: if [ ! -d "${STATEFUL_DIR}/var_new" ] || \
no need for trailing \

http://codereview.chromium.org/6626028/diff/1/stateful_update#newcode68
stateful_update:68: touch "${STATEFUL_DIR}/.update_available"
echo -n "" > .update_available

Powered by Google App Engine
This is Rietveld 408576698