Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/renderer/autofill/form_autocomplete_browsertest.cc

Issue 6625087: Convert autofill messages to use the new IPC macros (again). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/renderer/autofill/autofill_agent.cc ('k') | chrome/renderer/autofill/form_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/autofill_messages.h" 5 #include "chrome/common/autofill_messages.h"
6 #include "chrome/test/render_view_test.h" 6 #include "chrome/test/render_view_test.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h" 8 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
9 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFormElement.h" 9 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFormElement.h"
10 #include "third_party/WebKit/Source/WebKit/chromium/public/WebString.h" 10 #include "third_party/WebKit/Source/WebKit/chromium/public/WebString.h"
(...skipping 22 matching lines...) Expand all
33 33
34 const IPC::Message* message = render_thread_.sink().GetFirstMessageMatching( 34 const IPC::Message* message = render_thread_.sink().GetFirstMessageMatching(
35 AutoFillHostMsg_FormSubmitted::ID); 35 AutoFillHostMsg_FormSubmitted::ID);
36 ASSERT_TRUE(message != NULL); 36 ASSERT_TRUE(message != NULL);
37 37
38 Tuple1<FormData> forms; 38 Tuple1<FormData> forms;
39 AutoFillHostMsg_FormSubmitted::Read(message, &forms); 39 AutoFillHostMsg_FormSubmitted::Read(message, &forms);
40 ASSERT_EQ(2U, forms.a.fields.size()); 40 ASSERT_EQ(2U, forms.a.fields.size());
41 41
42 webkit_glue::FormField& form_field = forms.a.fields[0]; 42 webkit_glue::FormField& form_field = forms.a.fields[0];
43 EXPECT_EQ(WebString("fname"), form_field.name()); 43 EXPECT_EQ(WebString("fname"), form_field.name);
44 EXPECT_EQ(WebString("Rick"), form_field.value()); 44 EXPECT_EQ(WebString("Rick"), form_field.value);
45 45
46 form_field = forms.a.fields[1]; 46 form_field = forms.a.fields[1];
47 EXPECT_EQ(WebString("lname"), form_field.name()); 47 EXPECT_EQ(WebString("lname"), form_field.name);
48 EXPECT_EQ(WebString("Deckard"), form_field.value()); 48 EXPECT_EQ(WebString("Deckard"), form_field.value);
49 } 49 }
50 50
51 // Tests that submitting a form that has autocomplete="off" does not generate a 51 // Tests that submitting a form that has autocomplete="off" does not generate a
52 // FormSubmitted message. 52 // FormSubmitted message.
53 TEST_F(FormAutocompleteTest, AutoCompleteOffFormSubmit) { 53 TEST_F(FormAutocompleteTest, AutoCompleteOffFormSubmit) {
54 // Load a form. 54 // Load a form.
55 LoadHTML("<html><form id='myForm' autocomplete='off'>" 55 LoadHTML("<html><form id='myForm' autocomplete='off'>"
56 "<input name='fname' value='Rick'/>" 56 "<input name='fname' value='Rick'/>"
57 "<input name='lname' value='Deckard'/>" 57 "<input name='lname' value='Deckard'/>"
58 "</form></html>"); 58 "</form></html>");
(...skipping 22 matching lines...) Expand all
81 // No FormSubmitted message should have been sent. 81 // No FormSubmitted message should have been sent.
82 const IPC::Message* message = render_thread_.sink().GetFirstMessageMatching( 82 const IPC::Message* message = render_thread_.sink().GetFirstMessageMatching(
83 AutoFillHostMsg_FormSubmitted::ID); 83 AutoFillHostMsg_FormSubmitted::ID);
84 ASSERT_TRUE(message != NULL); 84 ASSERT_TRUE(message != NULL);
85 85
86 Tuple1<FormData> forms; 86 Tuple1<FormData> forms;
87 AutoFillHostMsg_FormSubmitted::Read(message, &forms); 87 AutoFillHostMsg_FormSubmitted::Read(message, &forms);
88 ASSERT_EQ(1U, forms.a.fields.size()); 88 ASSERT_EQ(1U, forms.a.fields.size());
89 89
90 webkit_glue::FormField& form_field = forms.a.fields[0]; 90 webkit_glue::FormField& form_field = forms.a.fields[0];
91 EXPECT_EQ(WebString("fname"), form_field.name()); 91 EXPECT_EQ(WebString("fname"), form_field.name);
92 EXPECT_EQ(WebString("Rick"), form_field.value()); 92 EXPECT_EQ(WebString("Rick"), form_field.value);
93 } 93 }
94 94
95 // Tests that submitting a form that has been dynamically set as autocomplete 95 // Tests that submitting a form that has been dynamically set as autocomplete
96 // off does not generate a FormSubmitted message. 96 // off does not generate a FormSubmitted message.
97 // http://crbug.com/36520 97 // http://crbug.com/36520
98 // TODO(jcampan): Waiting on WebKit bug 35823. 98 // TODO(jcampan): Waiting on WebKit bug 35823.
99 TEST_F(FormAutocompleteTest, FAILS_DynamicAutoCompleteOffFormSubmit) { 99 TEST_F(FormAutocompleteTest, FAILS_DynamicAutoCompleteOffFormSubmit) {
100 LoadHTML("<html><form id='myForm'><input name='fname' value='Rick'/>" 100 LoadHTML("<html><form id='myForm'><input name='fname' value='Rick'/>"
101 "<input name='lname' value='Deckard'/></form></html>"); 101 "<input name='lname' value='Deckard'/></form></html>");
102 102
103 WebKit::WebElement element = 103 WebKit::WebElement element =
104 GetMainFrame()->document().getElementById(WebKit::WebString("myForm")); 104 GetMainFrame()->document().getElementById(WebKit::WebString("myForm"));
105 ASSERT_FALSE(element.isNull()); 105 ASSERT_FALSE(element.isNull());
106 WebKit::WebFormElement form = element.to<WebKit::WebFormElement>(); 106 WebKit::WebFormElement form = element.to<WebKit::WebFormElement>();
107 EXPECT_TRUE(form.autoComplete()); 107 EXPECT_TRUE(form.autoComplete());
108 108
109 // Dynamically mark the form as autocomplete off. 109 // Dynamically mark the form as autocomplete off.
110 ExecuteJavaScript("document.getElementById('myForm').autocomplete='off';"); 110 ExecuteJavaScript("document.getElementById('myForm').autocomplete='off';");
111 ProcessPendingMessages(); 111 ProcessPendingMessages();
112 EXPECT_FALSE(form.autoComplete()); 112 EXPECT_FALSE(form.autoComplete());
113 113
114 // Submit the form. 114 // Submit the form.
115 ExecuteJavaScript("document.getElementById('myForm').submit();"); 115 ExecuteJavaScript("document.getElementById('myForm').submit();");
116 ProcessPendingMessages(); 116 ProcessPendingMessages();
117 117
118 // No FormSubmitted message should have been sent. 118 // No FormSubmitted message should have been sent.
119 EXPECT_FALSE(render_thread_.sink().GetFirstMessageMatching( 119 EXPECT_FALSE(render_thread_.sink().GetFirstMessageMatching(
120 AutoFillHostMsg_FormSubmitted::ID)); 120 AutoFillHostMsg_FormSubmitted::ID));
121 } 121 }
OLDNEW
« no previous file with comments | « chrome/renderer/autofill/autofill_agent.cc ('k') | chrome/renderer/autofill/form_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698